[WIP] OCPBUGS-43004: Allow default network pods to reach localnet on the same node#2467
[WIP] OCPBUGS-43004: Allow default network pods to reach localnet on the same node#2467ricky-rav wants to merge 2 commits intoopenshift:masterfrom
Conversation
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-43004, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricky-rav The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
8bc6cb3 to
f856d80
Compare
|
/retest |
|
The current changes don't work with local gateway mode because the |
1bf3c66 to
adbe68e
Compare
|
/retest |
Add a flow at prio=101 to allow traffic from the OVN network to the host network to be handled normally by the bridge instead of forwarding it directly to the NIC (which would be done by the flow at prio=100). This allows pods in the default network to reach localnet pods on the same node. Add two extra flows for icmpv6 to allow neighbor solicitation and neighbor advertisement messages to pass. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com> (cherry picked from commit 56c35d76f77843c3a9d95c0b4520dad0b495fd97) (cherry picked from commit bd488ed94ef5fed0c9fd53e8c9c38ae4c00edc35)
Add e2e tests where a server pod is connected to a secondary localnet and pods in the default network try to reach the server pod on its localnet interface. The localnet is plugged to breth0 and IPs on the localnet interface are drawn from the subnets of the node primary interface addresses. Two cases to check: - client and server pods are on different nodes (works with existing code) - client and server pods are on the same node (works thanks to the previous commit with extra openflow rule at prio=101) Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com> (cherry picked from commit 9827ae07a787623fce14d4466fdaa3af1bce82fe) (cherry picked from commit d62054494bfef24e75d7a4b4abf34ba009469430)
adbe68e to
8235f62
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@ricky-rav: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add a flow at prio=101 to allow traffic from the OVN network to the host network to be handled normally by the bridge instead of forwarding it directly to the NIC (which would be done by the flow at prio=100). This allows pods in the default network to reach localnet pods on the same node.
Testing upstream changes ovn-kubernetes/ovn-kubernetes#5041