Fix Sync netpol ACL filter

[npinaeva]

Fix syncNetworkPolicy ACLs filter to not include multicast ACLs, since
multicast ACLs have similar ExternalIDs, but different priority.

Was introduced in 4.13 #1603 and not backported.
Fixed in 4.14 since ovn-kubernetes/ovn-kubernetes@2aab19e#diff-cc83e19af1c257d5a09b711d5977d8f8c20beb34b7b5d3eb37b2f2c53ded1bf7R293-R295

[openshift-ci-robot]

@npinaeva: This pull request references Jira Issue OCPBUGS-21668, which is invalid:

• bug is open, matching expected state (open)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• bug has dependents
• dependent bug SDN-4191 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fix syncNetworkPolicy ACLs filter to not include multicast ACLs, since
multicast ACLs have similar ExternalIDs, but different priority.

Was introduced in 4.13 #1603 and not backported.
Fixed in 4.14 since ovn-kubernetes/ovn-kubernetes@2aab19e#diff-cc83e19af1c257d5a09b711d5977d8f8c20beb34b7b5d3eb37b2f2c53ded1bf7R293-R295

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: npinaeva
Once this PR has been reviewed and has the lgtm label, please assign dcbw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@npinaeva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn	8b49f95	link	false	/test e2e-vsphere-ovn
ci/prow/4.13-upgrade-from-stable-4.12-local-gateway-e2e-aws-ovn-upgrade	8b49f95	link	true	/test 4.13-upgrade-from-stable-4.12-local-gateway-e2e-aws-ovn-upgrade
ci/prow/4.13-upgrade-from-stable-4.12-local-gateway-images	8b49f95	link	true	/test 4.13-upgrade-from-stable-4.12-local-gateway-images
ci/prow/4.13-upgrade-from-stable-4.12-e2e-aws-ovn-upgrade	8b49f95	link	true	/test 4.13-upgrade-from-stable-4.12-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-windows	8b49f95	link	true	/test e2e-aws-ovn-windows
ci/prow/security	8b49f95	link	false	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@npinaeva: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Fix syncNetworkPolicy ACLs filter to not include multicast ACLs, since
multicast ACLs have similar ExternalIDs, but different priority.

Was introduced in 4.13 #1603 and not backported.
Fixed in 4.14 since ovn-kubernetes/ovn-kubernetes@2aab19e#diff-cc83e19af1c257d5a09b711d5977d8f8c20beb34b7b5d3eb37b2f2c53ded1bf7R293-R295

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[npinaeva]

The intent was to fix network policy port groups being wrongly deleted because of interpreting multicast ACLs as netpol ACLs. Even though multicast ACL can actually give here either a real namespace name or "clusterRtrPortGroup", extra check https://github.com/openshift/ovn-kubernetes/blob/release-4.13/go-controller/pkg/ovn/policy.go#L352 won't let it delete network policy that actually exists. Also deleting a port group that doesn't exist won't return an error https://github.com/openshift/ovn-kubernetes/blob/master/go-controller/pkg/libovsdb/ops/portgroup.go#L263
So closing, since it doesn't cause a real problem