Skip to content

OCPBUGS-17675: Don't return error on delete event that doesn't ave a chance to succeed.#1814

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.12from
npinaeva:ocpbugs-17675
Aug 20, 2023
Merged

OCPBUGS-17675: Don't return error on delete event that doesn't ave a chance to succeed.#1814
openshift-merge-robot merged 1 commit intoopenshift:release-4.12from
npinaeva:ocpbugs-17675

Conversation

@npinaeva
Copy link
Copy Markdown
Contributor

@npinaeva npinaeva commented Aug 14, 2023

Besides unneeded logging it may cause update event that was received after delete event to be never handled, since retry framework will not proceed to the update handler until delete handler succeeds. Was fixed in newer versions with 120140f (pod_selector_address_set)
Merged downstream here #1603 (4.13), https://github.com/openshift/ovn-kubernetes/pull/1603/files#diff-7375899468809f8394c8c50f436167aa32368e3dac1eb0c25d05e6b9b0e2cbe3R354-R359
loglevel was updated to warning here ovn-kubernetes/ovn-kubernetes@8e95a64

@npinaeva
Don't return error on delete event that doesn't ave a chance to succeed.
0392c8e 
Besides unneeded logging it may cause update event that was received
after delete event to be never handled, since retry framework will not
proceed to the update handler until delete handler succeeds.
Was fixed in newer versions with 120140f
(pod_selector_address_set)

Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 14, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 14, 2023

@npinaeva: This pull request references Jira Issue OCPBUGS-17675, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-10799 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-10799 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Besides unneeded logging it may cause update event that was received after delete event to be never handled, since retry framework will not proceed to the update handler until delete handler succeeds. Was fixed in newer versions with 120140f (pod_selector_address_set)
Merged downstream here #1603 (4.13), https://github.com/openshift/ovn-kubernetes/pull/1603/files#diff-7375899468809f8394c8c50f436167aa32368e3dac1eb0c25d05e6b9b0e2cbe3R354-R359
loglevel was updated to warning here ovn-kubernetes/ovn-kubernetes@8e95a64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andreaskaris
Copy link
Copy Markdown
Contributor

andreaskaris commented Aug 14, 2023

/retest-required

1 similar comment
@npinaeva
Copy link
Copy Markdown
Contributor Author

npinaeva commented Aug 15, 2023

/retest-required

@andreaskaris
Copy link
Copy Markdown
Contributor

andreaskaris commented Aug 15, 2023

/retest-failed

3 similar comments
@npinaeva
Copy link
Copy Markdown
Contributor Author

npinaeva commented Aug 15, 2023

/retest-failed

@andreaskaris
Copy link
Copy Markdown
Contributor

andreaskaris commented Aug 15, 2023

/retest-failed

@npinaeva
Copy link
Copy Markdown
Contributor Author

npinaeva commented Aug 16, 2023

/retest-failed

@npinaeva
Copy link
Copy Markdown
Contributor Author

npinaeva commented Aug 16, 2023

/retest-required

@npinaeva
Copy link
Copy Markdown
Contributor Author

npinaeva commented Aug 16, 2023

/tide refresh

@trozet
Copy link
Copy Markdown
Contributor

trozet commented Aug 17, 2023

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 17, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npinaeva, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023
@zhaozhanqi
Copy link
Copy Markdown
Contributor

zhaozhanqi commented Aug 17, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 17, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 17, 2023

/retest-required

Remaining retests: 0 against base HEAD 6e552fe and 2 for PR HEAD 0392c8e in total

@andreaskaris
Copy link
Copy Markdown
Contributor

andreaskaris commented Aug 18, 2023

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Aug 18, 2023 •
edited
Loading

@npinaeva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-hypershift 0392c8e link false /test e2e-aws-ovn-hypershift
ci/prow/e2e-ovn-hybrid-step-registry 0392c8e link false /test e2e-ovn-hybrid-step-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Aug 20, 2023

/override ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration
/override ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Aug 20, 2023

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration, ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration

Details

In response to this:

/override ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration
/override ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 5b27aa0 into openshift:release-4.12 Aug 20, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 20, 2023

@npinaeva: Jira Issue OCPBUGS-17675: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17675 has been moved to the MODIFIED state.

Details

In response to this:

Besides unneeded logging it may cause update event that was received after delete event to be never handled, since retry framework will not proceed to the update handler until delete handler succeeds. Was fixed in newer versions with 120140f (pod_selector_address_set)
Merged downstream here #1603 (4.13), https://github.com/openshift/ovn-kubernetes/pull/1603/files#diff-7375899468809f8394c8c50f436167aa32368e3dac1eb0c25d05e6b9b0e2cbe3R354-R359
loglevel was updated to warning here ovn-kubernetes/ovn-kubernetes@8e95a64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@npinaeva npinaeva deleted the ocpbugs-17675 branch September 25, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@abhat abhat Awaiting requested review from abhat

@jcaamano jcaamano Awaiting requested review from jcaamano

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@zhaozhanqi zhaozhanqi

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.