Skip to content

Test live migration 2#1716

Closed
qinqon wants to merge 6 commits intoopenshift:masterfrom
qinqon:test-live-migration-2
Closed

Test live migration 2#1716
qinqon wants to merge 6 commits intoopenshift:masterfrom
qinqon:test-live-migration-2

Conversation

@qinqon
Copy link
Contributor

@qinqon qinqon commented Jun 20, 2023

#1714 + latest live migration

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qinqon
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

qinqon added 5 commits June 20, 2023 17:22
Instead of disable ip config when the live migration annotation is found
this change generalize is and add a flag to pod-networks so users can
disable it per pod interface.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
At live migration the IP has to follow the VM and at kubevirt it means
that the new virt-launcher pod has to re-use the address from the old
virt-launcher. This change annotate the virt-launcher pods with the
switch owning the subnet so it's possible to query the IPAM system with
the proper switch after live migration

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
The hypershift workers use DHCP for IP configuration, this
change configure the ipv4/ipv6 DHCP options from the VM's LSP with the
cidr from switch subnet, harcode arp proxy IP as default gw and the dns
server from kubernetes or openshift service, it also configure the
"arp_proxy" option at the LSP.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Live migrated pods will keep their IP and it will be from a subnet
different from the node switch, to continue routing to the proper node a
point to point route need to be added to ovn_cluster_router that will
change at live migration. This change add that route and implement the
live migration switch.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
This change add e2e tests to check pre and post copy live migration, for
that the "kind.sh" script has learn to install kubevirt. Github actions
also include jobs to exercise it, the post-copy test has being disabled
for them since it's not working at that env.

To test that tcp connection survives live migration http connection
reuse is check.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon qinqon force-pushed the test-live-migration-2 branch from 1fdd84f to cf52cdd Compare June 20, 2023 15:22
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

@qinqon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-kubevirt cf52cdd link true /test e2e-aws-ovn-kubevirt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qinqon qinqon closed this Jul 19, 2023
@qinqon qinqon deleted the test-live-migration-2 branch July 19, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants