Skip to content

[release-4.13] OCPBUGS-15140: Fix stale SNAT entries for completed pods#1715

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
pperiyasamy:stale-snat-complete-pods-4.13
Jun 20, 2023
Merged

[release-4.13] OCPBUGS-15140: Fix stale SNAT entries for completed pods#1715
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
pperiyasamy:stale-snat-complete-pods-4.13

Conversation

@pperiyasamy
Copy link
Member

@pperiyasamy pperiyasamy commented Jun 19, 2023

In case of completed pod case, egress ip module is handling pod add, egressip events as usual and when logical port is found, it proceeds with programming SNAT and LRP for pod ip address which is not required. Also when pod is done or completed, then it's not required to recreate SNAT entry referring to node ip address. Hence this commit addresses these two issues so that no stale or duplicate SNAT entries present for a pod.

Manually resolved conflicts:

go-controller/pkg/ovn/namespace.go

Signed-off-by: Periyasamy Palanisamy pepalani@redhat.com
(cherry picked from commit 7b88e0a)

@pperiyasamy
Fix stale SNAT entries for completed pods
cd99b41 
In case of completed pod case, egress ip module is handling pod add,
egressip events as usual and when logical port is found, it proceeds
with programming SNAT and LRP for pod ip address which is not required.
Also when pod is done or completed, then it's not required to recreate
SNAT entry referring to node ip address. Hence this commit addresses
these two issues so that no stale or duplicate SNAT entries present
for a pod.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
(cherry picked from commit 7b88e0a)
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 19, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 19, 2023

@pperiyasamy: This pull request references Jira Issue OCPBUGS-15140, which is invalid:

  • expected the bug to target the "4.13.z" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

In case of completed pod case, egress ip module is handling pod add, egressip events as usual and when logical port is found, it proceeds with programming SNAT and LRP for pod ip address which is not required. Also when pod is done or completed, then it's not required to recreate SNAT entry referring to node ip address. Hence this commit addresses these two issues so that no stale or duplicate SNAT entries present for a pod.

Manually resolved conflicts:

go-controller/pkg/ovn/namespace.go

Signed-off-by: Periyasamy Palanisamy pepalani@redhat.com
(cherry picked from commit 7b88e0a)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pperiyasamy
Copy link
Member Author

pperiyasamy commented Jun 19, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 19, 2023

@pperiyasamy: This pull request references Jira Issue OCPBUGS-15140, which is invalid:

  • expected the bug to target the "4.13.z" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jcaamano and tssurya June 19, 2023 07:55
@pperiyasamy
Copy link
Member Author

pperiyasamy commented Jun 19, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 19, 2023

@pperiyasamy: This pull request references Jira Issue OCPBUGS-15140, which is invalid:

  • expected the bug to target the "4.13.z" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pperiyasamy
Copy link
Member Author

pperiyasamy commented Jun 19, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 19, 2023

@pperiyasamy: This pull request references Jira Issue OCPBUGS-15140, which is invalid:

  • expected the bug to target the "4.13.z" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor

jcaamano commented Jun 19, 2023

/lgtm
/approved
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 19, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@pperiyasamy
Copy link
Member Author

pperiyasamy commented Jun 19, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 19, 2023

@pperiyasamy: This pull request references Jira Issue OCPBUGS-15140, which is invalid:

  • expected the bug to target the "4.13.z" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jechen0648
Copy link
Contributor

jechen0648 commented Jun 19, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 19, 2023
@jechen0648
Copy link
Contributor

jechen0648 commented Jun 19, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

@pperiyasamy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dcbw
Copy link
Contributor

dcbw commented Jun 20, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 20, 2023

@dcbw: This pull request references Jira Issue OCPBUGS-15140, which is invalid:

  • expected the bug to target the "4.13.z" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Jun 20, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 20, 2023

@dcbw: This pull request references Jira Issue OCPBUGS-15140, which is invalid:

  • expected the bug to target the "4.13.z" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Jun 20, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 20, 2023

@dcbw: This pull request references Jira Issue OCPBUGS-15140, which is invalid:

  • expected the bug to target the "4.13.z" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Jun 20, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 20, 2023

@dcbw: This pull request references Jira Issue OCPBUGS-15140, which is invalid:

  • expected the bug to target the "4.13.z" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlexNPavel
Copy link

AlexNPavel commented Jun 20, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 20, 2023

@AlexNPavel: This pull request references Jira Issue OCPBUGS-15140, which is valid. The bug has been moved to the POST state.

8 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-11925 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent bug Jira Issue OCPBUGS-11925 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-11925 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • dependent Jira Issue OCPBUGS-11925 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 723ce84 into openshift:release-4.13 Jun 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 20, 2023

@pperiyasamy: Jira Issue OCPBUGS-15140: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15140 has been moved to the MODIFIED state.

Details

In response to this:

In case of completed pod case, egress ip module is handling pod add, egressip events as usual and when logical port is found, it proceeds with programming SNAT and LRP for pod ip address which is not required. Also when pod is done or completed, then it's not required to recreate SNAT entry referring to node ip address. Hence this commit addresses these two issues so that no stale or duplicate SNAT entries present for a pod.

Manually resolved conflicts:

go-controller/pkg/ovn/namespace.go

Signed-off-by: Periyasamy Palanisamy pepalani@redhat.com
(cherry picked from commit 7b88e0a)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dwkop dwkop mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcaamano jcaamano Awaiting requested review from jcaamano

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@zhaozhanqi zhaozhanqi

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.