[release-4.13] OCPBUGS-14492: Backport OVN component templates for NodePort services. by dceara · Pull Request #1709 · openshift/ovn-kubernetes

dceara · 2023-06-15T10:39:54Z

- What this PR does and why is it needed
This is a backport to 4.13 of the LB Templates implementation of NodePort services. It includes the commits from the following upstream PRs:

- Special notes for reviewers

- How to verify it

- Description for the changelog

dceara · 2023-06-15T10:41:57Z

CC: @abhat @dcbw @trozet @tssurya @jcaamano

dceara · 2023-06-15T21:39:37Z

ci/prow/e2e-vsphere-windows failure after the test stage while:

 INFO[2023-06-15T16:51:14Z] Running step e2e-vsphere-windows-gather-extra. 
{"component":"entrypoint","file":"k8s.io/test-infra/prow/entrypoint/run.go:164","func":"k8s.io/test-infra/prow/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 4h0m0s timeout","severity":"error","time":"2023-06-15T16:52:16Z"}
INFO[2023-06-15T16:52:16Z] Received signal.                              signal=interrupt

dceara · 2023-06-15T21:39:44Z

/test e2e-vsphere-windows

dceara · 2023-06-15T21:52:25Z

ci/prow/e2e-vsphere-ovn failure seems to happen with other PRs too:

[sig-storage] In-tree Volumes [Driver: vsphere] [Testpattern: Dynamic PV (default fs)] provisioning should mount multiple PV pointing to the same storage on the same node [Suite:openshift/conformance/parallel] [Suite:k8s]

dceara · 2023-06-15T21:52:30Z

/test e2e-vsphere-ovn

dceara · 2023-06-15T21:58:43Z

ci/prow/e2e-openstack-ovn failure seems unrelated:

[sig-arch][Late] operators should not create watch channels very often [apigroup:apiserver.openshift.io] [Suite:openshift/conformance/parallel]

dceara · 2023-06-15T21:58:47Z

/test e2e-openstack-ovn

dceara · 2023-06-15T22:11:29Z

ci/prow/e2e-aws-ovn-windows failed to install cluster:

level=error msg=StaticPodsDegraded: pod/kube-controller-manager-ip-10-0-237-217.ec2.internal container "kube-controller-manager-recovery-controller" is terminated: Completed: 
level=info msg=Cluster operator kube-controller-manager Progressing is True with NodeInstaller: NodeInstallerProgressing: 1 nodes are at revision 5; 2 nodes are at revision 6
level=info msg=Cluster operator network ManagementStateDegraded is False with : 
level=error msg=Cluster initialization failed because one or more operators are not functioning properly.
level=error msg=The cluster should be accessible for troubleshooting as detailed in the documentation linked below,
level=error msg=https://docs.openshift.com/container-platform/latest/support/troubleshooting/troubleshooting-installations.html
level=error msg=The 'wait-for install-complete' subcommand can then be used to continue the installation
level=error msg=failed to initialize the cluster: Cluster operator kube-controller-manager is degraded
Installer exit with code 6

dceara · 2023-06-15T22:11:44Z

/test e2e-aws-ovn-windows

dceara · 2023-06-16T07:54:41Z

/retest

dceara · 2023-06-16T13:27:02Z

/retest

dceara · 2023-06-19T15:11:20Z

/retest

dceara · 2023-06-23T13:56:29Z

Depends on #1708

dceara · 2023-06-23T13:56:48Z

/retest

openshift-ci-robot · 2023-06-27T11:02:41Z

@dceara: This pull request references Jira Issue OCPBUGS-14492, which is invalid:

expected Jira Issue OCPBUGS-14492 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What this PR does and why is it needed
This is a backport to 4.13 of the LB Templates implementation of NodePort services. It includes the commits from the following upstream PRs:

Use OVN component templates for NodePort services.

services: Don't try to list/cleanup templates when OVN doesn't support that.

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dceara · 2023-06-27T11:08:14Z

/jira refresh

openshift-ci-robot · 2023-06-27T11:08:23Z

@dceara: This pull request references Jira Issue OCPBUGS-14492, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.z) matches configured target version for branch (4.13.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-9825 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-9825 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dceara · 2023-06-27T11:09:21Z

/hold
This still depends on #1708 being merged first.

dceara · 2023-07-04T17:18:00Z

The failure seems unrelated:

[sig-metal] should get working host from infra provider
{  ofcir: Failed to create ci resource: ipi-ci-op-s6zn5fx9-472d2-1676214644789743616}

dceara · 2023-07-04T17:18:08Z

/retest

openshift-ci · 2023-07-04T19:49:36Z

@dceara: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

abhat · 2023-07-05T11:01:16Z

@dceara can you remove the hold? The dockerfile bumps that you referred to in 1708 are already in this PR too. Can we just close 1708?

dcbw · 2023-07-05T15:47:23Z

/hold cancel
/approve

abhat · 2023-07-05T15:51:46Z

/payload 4.13 nightly blocking

openshift-ci · 2023-07-05T15:51:50Z

@abhat: trigger 6 job(s) of type blocking for the nightly release of OCP 4.13

periodic-ci-openshift-release-master-nightly-4.13-e2e-aws-sdn-serial
periodic-ci-openshift-release-master-nightly-4.13-e2e-aws-sdn-upgrade
periodic-ci-openshift-release-master-ci-4.13-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-master-ci-4.13-upgrade-from-stable-4.12-e2e-gcp-ovn-rt-upgrade
periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-ovn-ipv6
periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-sdn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d885d250-1b4b-11ee-9996-5320262c49e0-0

jcaamano · 2023-07-05T16:39:54Z

Missed the originating commit for cherrypick [release-4.13] OCPBUGS-14492: Backport OVN component templates for NodePort services.

jcaamano · 2023-07-05T16:40:30Z

/lgtm
/approve
/label backport-risk-assessed

openshift-ci · 2023-07-05T16:41:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, dceara, jcaamano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dcbw,jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

abhat · 2023-07-06T18:55:41Z

/payload 4.13 nightly blocking

openshift-ci · 2023-07-06T18:55:43Z

@abhat: trigger 6 job(s) of type blocking for the nightly release of OCP 4.13

periodic-ci-openshift-release-master-nightly-4.13-e2e-aws-sdn-serial
periodic-ci-openshift-release-master-nightly-4.13-e2e-aws-sdn-upgrade
periodic-ci-openshift-release-master-ci-4.13-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-master-ci-4.13-upgrade-from-stable-4.12-e2e-gcp-ovn-rt-upgrade
periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-ovn-ipv6
periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-sdn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b4422090-1c2e-11ee-97b7-044a2098029e-0

asood-rh · 2023-07-06T19:00:02Z

/label cherry-pick-approved

openshift-ci-robot · 2023-07-06T19:03:36Z

@dceara: Jira Issue OCPBUGS-14492: All pull requests linked via external trackers have merged:

openshift/ovn-kubernetes#1709

Jira Issue OCPBUGS-14492 has been moved to the MODIFIED state.

Details

In response to this:

- What this PR does and why is it needed
This is a backport to 4.13 of the LB Templates implementation of NodePort services. It includes the commits from the following upstream PRs:

Use OVN component templates for NodePort services.

services: Don't try to list/cleanup templates when OVN doesn't support that.

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2023

openshift-ci bot requested review from JacobTanenbaum and jcaamano June 15, 2023 10:40

dceara force-pushed the lb-templates-4.13 branch 2 times, most recently from cdec71a to 87ce418 Compare June 15, 2023 12:51

dceara changed the title ~~[WIP] [release-4.13] Backport OVN component templates for NodePort services.~~ [release-4.13] OCPBUGS-14492: Backport OVN component templates for NodePort services. Jun 27, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 27, 2023

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 27, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 27, 2023

openshift-ci bot requested a review from anuragthehatter June 27, 2023 11:08

openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 5, 2023

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 5, 2023

openshift-ci bot assigned anuragthehatter, asood-rh, huiran0826, jechen0648, mffiedler, qiowang721, rbbratta, weliang1, yingwang-0320 and zhaozhanqi Jul 5, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 6, 2023

openshift-merge-robot merged commit 02a0209 into openshift:release-4.13 Jul 6, 2023

Conversation

dceara commented Jun 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dceara commented Jun 15, 2023

Uh oh!

dceara commented Jun 15, 2023

Uh oh!

dceara commented Jun 15, 2023

Uh oh!

dceara commented Jun 15, 2023

Uh oh!

dceara commented Jun 15, 2023

Uh oh!

dceara commented Jun 15, 2023

Uh oh!

dceara commented Jun 15, 2023

Uh oh!

dceara commented Jun 15, 2023

Uh oh!

dceara commented Jun 15, 2023

Uh oh!

dceara commented Jun 16, 2023

Uh oh!

dceara commented Jun 16, 2023

Uh oh!

dceara commented Jun 19, 2023

Uh oh!

dceara commented Jun 23, 2023

Uh oh!

dceara commented Jun 23, 2023

Uh oh!

openshift-ci-robot commented Jun 27, 2023

Uh oh!

dceara commented Jun 27, 2023

Uh oh!

openshift-ci-robot commented Jun 27, 2023

Uh oh!

dceara commented Jun 27, 2023

Uh oh!

dceara commented Jul 4, 2023

Uh oh!

dceara commented Jul 4, 2023

Uh oh!

openshift-ci bot commented Jul 4, 2023

Uh oh!

abhat commented Jul 5, 2023

Uh oh!

dcbw commented Jul 5, 2023

Uh oh!

abhat commented Jul 5, 2023

Uh oh!

openshift-ci bot commented Jul 5, 2023

Uh oh!

jcaamano commented Jul 5, 2023

Uh oh!

jcaamano commented Jul 5, 2023

Uh oh!

openshift-ci bot commented Jul 5, 2023

Uh oh!

abhat commented Jul 6, 2023

Uh oh!

openshift-ci bot commented Jul 6, 2023

Uh oh!

asood-rh commented Jul 6, 2023

Uh oh!

openshift-ci-robot commented Jul 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

dceara commented Jun 15, 2023 •

edited

Loading