Skip to content

OCPBUGS-12265: [release-4.12] Network scale metrics#1653

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.12from
npinaeva:ocpbugs-12265
Apr 28, 2023
Merged

OCPBUGS-12265: [release-4.12] Network scale metrics#1653
openshift-merge-robot merged 2 commits intoopenshift:release-4.12from
npinaeva:ocpbugs-12265

Conversation

@npinaeva
Copy link
Copy Markdown
Contributor

@npinaeva npinaeva commented Apr 21, 2023

Backport metrics from #1603
A lot of conflicts, but the resolution is usually very straightforward

npinaeva added 2 commits April 21, 2023 19:01
@npinaeva
Add MetricMasterSyncDuration metric to track how much it takes for
371e558 
ovn-k master to start watching every resource.
Add scale metrics for network policies, rename existing
enable-eip-scale-metrics flag to more general enable-scale-metrics, and
use it for network policy metric too.

Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
(cherry picked from commit 4a3f1dd)
(cherry picked from commit 6d96be9)

Conflicts:
	go-controller/pkg/ovn/default_network_controller.go - moved to ovn.go
	go-controller/pkg/ovn/egressip.go
	go-controller/pkg/ovn/ovn.go
	go-controller/pkg/ovn/policy.go
last 3 files DefaultNetworkController => Controller
@npinaeva
Add an option to enable scale metrics in kind
c16fe5a 
Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
(cherry picked from commit fbc9e4e)

Conflicts:
	contrib/kind.sh
	dist/images/ovnkube.sh
some args are not present
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 21, 2023

@npinaeva: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-12265: [release-4.12] Network scale metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 21, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 21, 2023

@npinaeva: This pull request references Jira Issue OCPBUGS-12265, which is invalid:

  • expected dependent Jira Issue OCPBUGS-10799 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport metrics from #1603
A lot of conflicts, but the resolution is usually very straightforward

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jcaamano and trozet April 21, 2023 17:15
@npinaeva
Copy link
Copy Markdown
Contributor Author

npinaeva commented Apr 24, 2023

/retest-required

@npinaeva
Copy link
Copy Markdown
Contributor Author

npinaeva commented Apr 24, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 24, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 24, 2023

@npinaeva: This pull request references Jira Issue OCPBUGS-12265, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-10799 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-10799 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (lhorsley@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 24, 2023
@npinaeva
Copy link
Copy Markdown
Contributor Author

npinaeva commented Apr 27, 2023

/retest-required

1 similar comment
@npinaeva
Copy link
Copy Markdown
Contributor Author

npinaeva commented Apr 27, 2023

/retest-required

trozet
trozet approved these changes Apr 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@trozet
Copy link
Copy Markdown
Contributor

trozet commented Apr 28, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Apr 28, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npinaeva, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023
@asood-rh
Copy link
Copy Markdown
Contributor

asood-rh commented Apr 28, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 28, 2023
@openshift-merge-robot openshift-merge-robot merged commit 49308a5 into openshift:release-4.12 Apr 28, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 28, 2023

@npinaeva: Jira Issue OCPBUGS-12265: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-12265 has been moved to the MODIFIED state.

Details

In response to this:

Backport metrics from #1603
A lot of conflicts, but the resolution is usually very straightforward

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 28, 2023

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.12.0-202304282241.p0.g49308a5.assembly.stream for distgit ovn-kubernetes-base.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 28, 2023

[ART PR BUILD NOTIFIER]

This PR has been included in build ovn-kubernetes-microshift-container-v4.12.0-202304282241.p0.g49308a5.assembly.stream for distgit ovn-kubernetes-microshift.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 28, 2023

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-container-v4.12.0-202304282241.p0.g49308a5.assembly.stream for distgit ose-ovn-kubernetes.
All builds following this will include this PR.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 28, 2023

@npinaeva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovn-hybrid-step-registry c16fe5a link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-aws-ovn-hypershift c16fe5a link false /test e2e-aws-ovn-hypershift
ci/prow/e2e-openstack-ovn c16fe5a link false /test e2e-openstack-ovn
ci/prow/e2e-azure-ovn c16fe5a link false /test e2e-azure-ovn
ci/prow/e2e-vsphere-ovn c16fe5a link false /test e2e-vsphere-ovn
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade c16fe5a link unknown /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade
ci/prow/4.12-upgrade-from-stable-4.11-local-gateway-e2e-aws-ovn-upgrade c16fe5a link unknown /test 4.12-upgrade-from-stable-4.11-local-gateway-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Apr 29, 2023

Fix included in accepted release 4.12.0-0.nightly-2023-04-29-195232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcaamano jcaamano Awaiting requested review from jcaamano

1 more reviewer

@trozet trozet trozet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@trozet trozet

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.