OCPBUGS-12212:[release-4.13]4.13 stack migration by bpickard22 · Pull Request #1651 · openshift/ovn-kubernetes

bpickard22 · 2023-04-20T19:25:55Z

Clean backport of @dcbw stack migration commits. Had to pull in ovn-kubernetes/ovn-kubernetes#3510, which also was clean and is already in 4.14 as the migration work is based on top of some of the changes there

Fix the formatting of the log messages (%w is only valid when creating new errors, not when logging) and update the master test suite name since it hasn't been only gateway init operations for a long time. Signed-off-by: Dan Williams <dcbw@redhat.com> (cherry picked from commit b14eb72) (cherry picked from commit eb4e2af)

today, ovnkube-master incorrectly assumes IPv6 is not enabled if no IPv6 is configured for default network, and fails to allocate IPv6 host subnets for secondary layer 3 networks with IPv6 subnets. Fixes: ovn-kubernetes/ovn-kubernetes#3168 Signed-off-by: Yun Zhou <yunz@nvidia.com> (cherry picked from commit df60b30)

…tion Remove the no-longer-used node host subnet annotation to allow the default network controller's node code to proceed. Also redo how the default network controller counts host subnets to make sure we actually have the right number of each IP family, rather than just counting numbers. Because the allocation handling was split out into the ClusterManager, the network controller's addNode() no longer has the guarantees of a correct set of annotations before it runs, as it and the cluster manager run in parallel. Signed-off-by: Dan Williams <dcbw@redhat.com> (cherry picked from commit 0c79228) (cherry picked from commit f05c0cf)

openshift-ci · 2023-04-20T19:26:00Z

@bpickard22: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-12212:[release-4.13]4.13 stack migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-04-20T19:26:02Z

@bpickard22: This pull request references Jira Issue OCPBUGS-12212, which is invalid:

expected the bug to target the "4.13.0" version, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Clean backport of dans stack migration commits. Had to pull in ovn-kubernetes/ovn-kubernetes#3510, which also was clean and is already in 4.14 as the migration work is based on top of some of the changes there

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bpickard22 · 2023-04-20T19:27:22Z

/jira refresh

openshift-ci-robot · 2023-04-20T19:27:31Z

@bpickard22: This pull request references Jira Issue OCPBUGS-12212, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-11534 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-11534 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-04-20T19:27:42Z

@bpickard22: This pull request references Jira Issue OCPBUGS-12212, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-11534 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-11534 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

Details

In response to this:

Clean backport of @dcbw stack migration commits. Had to pull in ovn-kubernetes/ovn-kubernetes#3510, which also was clean and is already in 4.14 as the migration work is based on top of some of the changes there

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-20T19:27:42Z

@bpickard22: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

OCPBUGS-12212:[release-4.13]4.13 stack migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bpickard22 · 2023-04-20T19:27:56Z

@dcbw @trozet PTAL

zshi-redhat · 2023-04-21T04:41:52Z

/retest-required

zhaozhanqi · 2023-04-21T07:31:13Z

pre-merge testing and looks good
with this PR, dualstack can convert to single and back to dualstack cluster
/label qe-approve

openshift-ci · 2023-04-21T07:31:15Z

@zhaozhanqi: The label(s) /label qe-approve cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

pre-merge testing and looks good
with this PR, dualstack can convert to single and back to dualstack cluster
/label qe-approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zhaozhanqi · 2023-04-21T07:31:38Z

/label qe-approved

jcaamano · 2023-04-24T15:40:39Z

/lgtm
/approved
/label backport-risk-assessed

openshift-ci · 2023-04-24T15:41:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpickard22, jcaamano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

anuragthehatter · 2023-04-24T16:23:59Z

/label cherry-pick-approved

openshift-ci · 2023-04-24T20:42:52Z

@bpickard22: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift	`49cca47`	link	false	`/test e2e-aws-ovn-hypershift`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-04-24T21:01:23Z

/retest-required

Remaining retests: 0 against base HEAD 8787b34 and 2 for PR HEAD 49cca47 in total

openshift-ci-robot · 2023-04-25T00:41:51Z

@bpickard22: Jira Issue OCPBUGS-12212: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-12212 has been moved to the MODIFIED state.

Details

In response to this:

Clean backport of @dcbw stack migration commits. Had to pull in ovn-kubernetes/ovn-kubernetes#3510, which also was clean and is already in 4.14 as the migration work is based on top of some of the changes there

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-04-28T05:18:54Z

Fix included in accepted release 4.13.0-0.nightly-2023-04-27-232707

dcbw and others added 3 commits April 20, 2023 14:15

openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Apr 20, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 20, 2023

openshift-ci bot requested review from abhat and trozet April 20, 2023 19:26

openshift-ci bot requested a review from zhaozhanqi April 20, 2023 19:27

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 21, 2023

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 24, 2023

openshift-ci bot assigned anuragthehatter, asood-rh, huiran0826 and jechen0648 Apr 24, 2023

openshift-ci bot assigned mffiedler, qiowang721, rbbratta, weliang1, yingwang-0320 and zhaozhanqi Apr 24, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 24, 2023

openshift-ci bot merged commit e114945 into openshift:release-4.13 Apr 25, 2023

Conversation

bpickard22 commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 20, 2023

Uh oh!

openshift-ci-robot commented Apr 20, 2023

Uh oh!

bpickard22 commented Apr 20, 2023

Uh oh!

openshift-ci-robot commented Apr 20, 2023

Uh oh!

openshift-ci-robot commented Apr 20, 2023

Uh oh!

openshift-ci bot commented Apr 20, 2023

Uh oh!

bpickard22 commented Apr 20, 2023

Uh oh!

zshi-redhat commented Apr 21, 2023

Uh oh!

zhaozhanqi commented Apr 21, 2023

Uh oh!

openshift-ci bot commented Apr 21, 2023

Uh oh!

zhaozhanqi commented Apr 21, 2023

Uh oh!

jcaamano commented Apr 24, 2023

Uh oh!

openshift-ci bot commented Apr 24, 2023

Uh oh!

anuragthehatter commented Apr 24, 2023

Uh oh!

openshift-ci bot commented Apr 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 24, 2023

Uh oh!

openshift-ci-robot commented Apr 25, 2023

Uh oh!

openshift-merge-robot commented Apr 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

bpickard22 commented Apr 20, 2023 •

edited

Loading

openshift-ci bot commented Apr 24, 2023 •

edited

Loading