Skip to content

OCPBUGS-10947: [release-4.12] Egress firewall fix retry#1610

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.12from
npinaeva:ocpbugs-10947
Mar 29, 2023
Merged

OCPBUGS-10947: [release-4.12] Egress firewall fix retry#1610
openshift-merge-robot merged 2 commits intoopenshift:release-4.12from
npinaeva:ocpbugs-10947

Conversation

@npinaeva
Copy link
Copy Markdown
Contributor

@npinaeva npinaeva commented Mar 28, 2023

cherry-pick of #1602

Conflicts:
go-controller/pkg/ovn/default_network_controller.go
move changes from default_network_controller to obj_retry_master

npinaeva added 2 commits March 28, 2023 10:14
@npinaeva
Egress firewall creation error was overridden by the status update
c43e230 
error and never returned. That would prevent retry on failure.

Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
(cherry picked from commit 66c8801)
(cherry picked from commit 2e3d170)

Conflicts:
	go-controller/pkg/ovn/default_network_controller.go
move changes from default_network_controller to obj_retry_master
@npinaeva
fix multiple error aggregation: errors.Wrapf always returns nil if the
8ce4aa4 
first argument is nil.

Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
(cherry picked from commit 11283d6)
(cherry picked from commit 74f95e9)
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 28, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 28, 2023

@npinaeva: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-10947: [release-4.12] Egress firewall fix retry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 28, 2023

@npinaeva: This pull request references Jira Issue OCPBUGS-10947, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-10796 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-10796 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @huiran0826

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

cherry-pick of #1602

Conflicts:
go-controller/pkg/ovn/default_network_controller.go
move changes from default_network_controller to obj_retry_master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dcbw, huiran0826 and trozet March 28, 2023 08:20
@huiran0826
Copy link
Copy Markdown
Contributor

huiran0826 commented Mar 28, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 28, 2023
@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Mar 29, 2023

/retest-required
/approve
/lgtm

@dcbw dcbw added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 29, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, npinaeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2023
@huiran0826
Copy link
Copy Markdown
Contributor

huiran0826 commented Mar 29, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 29, 2023
@npinaeva
Copy link
Copy Markdown
Contributor Author

npinaeva commented Mar 29, 2023

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 29, 2023

/retest-required

Remaining retests: 0 against base HEAD 78938a8 and 2 for PR HEAD 8ce4aa4 in total

@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Mar 29, 2023

/override ci/prow/e2e-vsphere-windows
https://redhat-internal.slack.com/archives/CM4ERHBJS/p1680032625731999

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 29, 2023

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-vsphere-windows

Details

In response to this:

/override ci/prow/e2e-vsphere-windows
https://redhat-internal.slack.com/archives/CM4ERHBJS/p1680032625731999

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Mar 29, 2023 •
edited
Loading

/override ci/prow/e2e-aws-ovn-upgrade-local-gateway

I can't find any indication that the cluster itself had problems during the this time; one of the sbdbs was started 3 minutes later than the other two, and it looks like the metric/alert itself triggers at a time when the DBs are known good.

The alert min_over_time(cluster:ovn_db_sbdb_not_cluster_member:abs[5m]) != 0 shows triggered from 17:30 to 17:40, but all SBs were available during that time.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 29, 2023

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-upgrade-local-gateway

Details

In response to this:

/override ci/prow/e2e-aws-ovn-upgrade-local-gateway

I can't find any indication that the cluster itself had problems during the this time; one of the sbdbs was started 3 minutes later than the other two, and it looks like the metric/alert itself triggers at a time when the DBs are known good.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 29, 2023

@npinaeva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 8ce4aa4 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-upgrade-local-gateway 8ce4aa4 link unknown /test e2e-aws-ovn-upgrade-local-gateway
ci/prow/e2e-vsphere-windows 8ce4aa4 link true /test e2e-vsphere-windows

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ffce71c into openshift:release-4.12 Mar 29, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 29, 2023

@npinaeva: Jira Issue OCPBUGS-10947: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10947 has been moved to the MODIFIED state.

Details

In response to this:

cherry-pick of #1602

Conflicts:
go-controller/pkg/ovn/default_network_controller.go
move changes from default_network_controller to obj_retry_master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@npinaeva npinaeva deleted the ocpbugs-10947 branch March 30, 2023 07:50
@npinaeva npinaeva mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huiran0826 huiran0826 Awaiting requested review from huiran0826

@dcbw dcbw Awaiting requested review from dcbw

@trozet trozet Awaiting requested review from trozet

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@zhaozhanqi zhaozhanqi

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.