OCPBUGS-10801: [release-4.13] Batch potentially big transaction on egress firewall ACLs migration by npinaeva · Pull Request #1604 · openshift/ovn-kubernetes

npinaeva · 2023-03-23T16:40:37Z

cherry-pick of ovn-kubernetes/ovn-kubernetes#3463
downstream #1574
clean cherry-pick

The default transaction timeout is 10 seconds, it can be reached when we delete all egress firewall acls during migration to port groups from switches. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com> (cherry picked from commit 1896e16)

stale acls. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com> (cherry picked from commit 81acdc2)

openshift-ci-robot · 2023-03-23T16:40:39Z

@npinaeva: An error was encountered updating to the POST state for bug OCPBUGS-10801 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


No transition status with name `POST` could be found. Please select from the following list: []

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

cherry-pick of ovn-kubernetes/ovn-kubernetes#3463
downstream #1574
clean cherry-pick

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-23T16:40:43Z

@npinaeva: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-10801: [release-4.13] Batch potentially big transaction on egress firewall ACLs migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trozet · 2023-03-24T13:58:48Z

/jira refresh

openshift-ci-robot · 2023-03-24T13:59:01Z

@trozet: This pull request references Jira Issue OCPBUGS-10801, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-7932 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-7932 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

Requesting review from QA contact:
/cc @huiran0826

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trozet · 2023-03-24T13:59:49Z

/lgtm
/label backport-risk-assessed

openshift-ci · 2023-03-24T14:00:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npinaeva, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

trozet · 2023-03-24T14:01:49Z

/retest-required

huiran0826 · 2023-03-29T06:03:34Z

/label qe-approved

huiran0826 · 2023-03-29T06:04:21Z

/label cherry-pick-approved

openshift-ci-robot · 2023-03-29T08:12:45Z

/retest-required

Remaining retests: 0 against base HEAD 8ae3593 and 2 for PR HEAD 34eb562 in total

openshift-ci · 2023-03-29T10:17:23Z

@npinaeva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-ovn	`34eb562`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-aws-ovn-hypershift	`34eb562`	link	false	`/test e2e-aws-ovn-hypershift`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

npinaeva · 2023-03-29T13:19:46Z

/retest-required

dcbw · 2023-03-29T14:24:18Z

/override ci/prow/e2e-aws-ovn-windows
https://redhat-internal.slack.com/archives/CM4ERHBJS/p1680098938285029

dcbw · 2023-03-29T14:35:01Z

/override ci/prow/e2e-aws-ovn-windows
https://redhat-internal.slack.com/archives/CM4ERHBJS/p1680098938285029

openshift-ci · 2023-03-29T14:38:20Z

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-windows

Details

In response to this:

/override ci/prow/e2e-aws-ovn-windows
https://redhat-internal.slack.com/archives/CM4ERHBJS/p1680098938285029

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-29T14:46:58Z

@npinaeva: Jira Issue OCPBUGS-10801: All pull requests linked via external trackers have merged:

openshift/ovn-kubernetes#1604

Jira Issue OCPBUGS-10801 has been moved to the MODIFIED state.

Details

In response to this:

cherry-pick of ovn-kubernetes/ovn-kubernetes#3463
downstream #1574
clean cherry-pick

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-29T14:48:56Z

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-windows

Details

In response to this:

/override ci/prow/e2e-aws-ovn-windows
https://redhat-internal.slack.com/archives/CM4ERHBJS/p1680098938285029

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

npinaeva · 2023-03-30T07:38:50Z

/cherry-pick release-4.12

openshift-cherrypick-robot · 2023-03-30T07:40:09Z

@npinaeva: #1604 failed to apply on top of branch "release-4.12":

Applying: Batch potentially big transaction on egress firewall ACLs migration. The default transaction timeout is 10 seconds, it can be reached when we delete all egress firewall acls during migration to port groups from switches.
Using index info to reconstruct a base tree...
M	go-controller/pkg/ovn/egressfirewall.go
Falling back to patching base and 3-way merge...
Auto-merging go-controller/pkg/ovn/egressfirewall.go
CONFLICT (content): Merge conflict in go-controller/pkg/ovn/egressfirewall.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Batch potentially big transaction on egress firewall ACLs migration. The default transaction timeout is 10 seconds, it can be reached when we delete all egress firewall acls during migration to port groups from switches.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

npinaeva added 2 commits March 23, 2023 17:38

Optimize egress firewall cleanup to only select switches that have

34eb562

stale acls. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com> (cherry picked from commit 81acdc2)

openshift-ci bot requested review from abhat and jcaamano March 23, 2023 16:42

openshift-ci bot requested a review from huiran0826 March 24, 2023 13:59

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 24, 2023

openshift-ci bot assigned anuragthehatter, asood-rh, huiran0826, jechen0648, mffiedler, qiowang721, rbbratta, weliang1, yingwang-0320 and zhaozhanqi Mar 24, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 29, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 29, 2023

openshift-merge-robot merged commit 9b3dfbb into openshift:release-4.13 Mar 29, 2023

npinaeva deleted the ocpbugs-7932 branch March 29, 2023 15:07

npinaeva mentioned this pull request Mar 30, 2023

OCPBUGS-11109: [release-4.12] Batch potentially big transaction on egress firewall ACLs migration #1617

Merged

Conversation

npinaeva commented Mar 23, 2023

Uh oh!

openshift-ci-robot commented Mar 23, 2023

Uh oh!

openshift-ci bot commented Mar 23, 2023

Uh oh!

trozet commented Mar 24, 2023

Uh oh!

openshift-ci-robot commented Mar 24, 2023

Uh oh!

trozet commented Mar 24, 2023

Uh oh!

openshift-ci bot commented Mar 24, 2023

Uh oh!

trozet commented Mar 24, 2023

Uh oh!

huiran0826 commented Mar 29, 2023

Uh oh!

huiran0826 commented Mar 29, 2023

Uh oh!

openshift-ci-robot commented Mar 29, 2023

Uh oh!

openshift-ci bot commented Mar 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

npinaeva commented Mar 29, 2023

Uh oh!

dcbw commented Mar 29, 2023

Uh oh!

dcbw commented Mar 29, 2023

Uh oh!

openshift-ci bot commented Mar 29, 2023

Uh oh!

openshift-ci-robot commented Mar 29, 2023

Uh oh!

openshift-ci bot commented Mar 29, 2023

Uh oh!

npinaeva commented Mar 30, 2023

Uh oh!

openshift-cherrypick-robot commented Mar 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

openshift-ci bot commented Mar 29, 2023 •

edited

Loading