[release-4.12] OCPBUGS-10632: Check the "Serving" field for endpoints #1569

ricky-rav · 2023-03-09T10:49:05Z

4.12 backport of f6ef433
Not a clean backport, because I had to account for the changes from 0111e1f, which are in 4.13 but not in 4.12.

Master, node and healthcheck code looked up the Ready field in endpoints inside endpointslices, in line with the previous implementation that dealt with the older and less fine-grained Endpoints resource, that only distinguished between ready and not ready. Healthchecks should indeed rely on the Ready field, while node and master could look up the "Serving" field, so that we won't prematurely refuse incoming connections to an endpoint that is scheduled to be terminating but is still up and running.

Making a special case for services with PublishNotReadyAddresses set, as their endpoints should always be considered ready, even if terminating. A couple of upstream kubernetes tests use this feature in 1.26.

Closes #OCPBUGS-10632

openshift-ci · 2023-03-09T10:49:12Z

@ricky-rav: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] Check the "Serving" field for endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-09T10:50:05Z

@ricky-rav: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] Check the "Serving" field for endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-09T11:03:20Z

@ricky-rav: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-9912: Check the "Serving" field for endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-09T11:03:23Z

@ricky-rav: This pull request references Jira Issue OCPBUGS-9912, which is invalid:

expected the bug to target the "4.12.z" version, but it targets "4.13" instead
expected Jira Issue OCPBUGS-9912 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

4.12 backport of f6ef433
Not a clean backport, because I had to account for the changes from 0111e1f, which are in 4.13 but not in 4.12.

Master, node and healthcheck code looked up the Ready field in endpoints inside endpointslices, in line with the previous implementation that dealt with the older and less fine-grained Endpoints resource, that only distinguished between ready and not ready. Healthchecks should indeed rely on the Ready field, while node and master could look up the "Serving" field, so that we won't prematurely refuse incoming connections to an endpoint that is scheduled to be terminating but is still up and running.

Making a special case for services with PublishNotReadyAddresses set, as their endpoints should always be considered ready, even if terminating. A couple of upstream kubernetes tests use this feature in 1.26.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-09T11:03:32Z

@ricky-rav: This pull request references Jira Issue OCPBUGS-9912, which is invalid:

expected the bug to target the "4.12.z" version, but it targets "4.13" instead
expected Jira Issue OCPBUGS-9912 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

4.12 backport of f6ef433
Not a clean backport, because I had to account for the changes from 0111e1f, which are in 4.13 but not in 4.12.

Master, node and healthcheck code looked up the Ready field in endpoints inside endpointslices, in line with the previous implementation that dealt with the older and less fine-grained Endpoints resource, that only distinguished between ready and not ready. Healthchecks should indeed rely on the Ready field, while node and master could look up the "Serving" field, so that we won't prematurely refuse incoming connections to an endpoint that is scheduled to be terminating but is still up and running.

Making a special case for services with PublishNotReadyAddresses set, as their endpoints should always be considered ready, even if terminating. A couple of upstream kubernetes tests use this feature in 1.26.

Closes #OCPBUGS-9912

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-09T11:03:33Z

@ricky-rav: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-9912: Check the "Serving" field for endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-09T11:04:15Z

@ricky-rav: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ricky-rav · 2023-03-09T11:04:33Z

/jira refresh

openshift-ci-robot · 2023-03-09T11:04:36Z

@ricky-rav: This pull request references Jira Issue OCPBUGS-9912, which is invalid:

expected Jira Issue OCPBUGS-9912 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ricky-rav · 2023-03-13T10:21:53Z

/retest-failed

ricky-rav · 2023-03-14T12:56:23Z

/retest-failed

openshift/origin#27794 merged 2 hours ago and should fix Should verify mounted devices can be resized

ricky-rav · 2023-03-14T13:39:03Z

/retest-required

ricky-rav · 2023-03-14T17:37:21Z

/retest-required

ricky-rav · 2023-03-14T20:52:44Z

/retest-required

ricky-rav · 2023-03-15T09:58:26Z

/retest-required

Master, node and healthcheck code looked up the Ready field in endpoints inside endpointslices, in line with the previous implementation that dealt with the older and less fine-grained Endpoints resource, that only distinguished between ready and not ready. Healthchecks should indeed rely on the Ready field, while node and master could look up the "Serving" field, so that we won't prematurely refuse incoming connections to an endpoint that is scheduled to be terminating but is still up and running. Making a special case for services with PublishNotReadyAddresses set, as their endpoints should always be considered ready, even if terminating. A couple of upstream kubernetes tests use this feature in 1.26. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com> (cherry picked from commit fd414d1)

ricky-rav · 2023-03-20T16:01:07Z

/retest-required

openshift-ci-robot · 2023-03-21T16:38:13Z

@ricky-rav: This pull request references Jira Issue OCPBUGS-10632, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.z) matches configured target version for branch (4.12.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-10631 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-10631 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

4.12 backport of f6ef433
Not a clean backport, because I had to account for the changes from 0111e1f, which are in 4.13 but not in 4.12.

Master, node and healthcheck code looked up the Ready field in endpoints inside endpointslices, in line with the previous implementation that dealt with the older and less fine-grained Endpoints resource, that only distinguished between ready and not ready. Healthchecks should indeed rely on the Ready field, while node and master could look up the "Serving" field, so that we won't prematurely refuse incoming connections to an endpoint that is scheduled to be terminating but is still up and running.

Making a special case for services with PublishNotReadyAddresses set, as their endpoints should always be considered ready, even if terminating. A couple of upstream kubernetes tests use this feature in 1.26.

Closes #OCPBUGS-10632

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-21T16:38:19Z

@ricky-rav: This pull request references Jira Issue OCPBUGS-10632, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.z) matches configured target version for branch (4.12.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-10631 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-10631 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

4.12 backport of f6ef433
Not a clean backport, because I had to account for the changes from 0111e1f, which are in 4.13 but not in 4.12.

Master, node and healthcheck code looked up the Ready field in endpoints inside endpointslices, in line with the previous implementation that dealt with the older and less fine-grained Endpoints resource, that only distinguished between ready and not ready. Healthchecks should indeed rely on the Ready field, while node and master could look up the "Serving" field, so that we won't prematurely refuse incoming connections to an endpoint that is scheduled to be terminating but is still up and running.

Making a special case for services with PublishNotReadyAddresses set, as their endpoints should always be considered ready, even if terminating. A couple of upstream kubernetes tests use this feature in 1.26.

Closes #OCPBUGS-9912

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-21T16:38:54Z

@ricky-rav: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

[release-4.12] OCPBUGS-10632: Check the "Serving" field for endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-21T16:38:55Z

@ricky-rav: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

[release-4.12] OCPBUGS-10632: Check the "Serving" field for endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ricky-rav · 2023-03-23T14:52:39Z

/retest-required

trozet

/lgtm

trozet · 2023-03-23T20:25:05Z

/label backport-risk-assessed

openshift-ci · 2023-03-23T20:25:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ricky-rav, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

anuragthehatter · 2023-03-24T14:03:52Z

/label cherry-pick-approved

openshift-ci-robot · 2023-03-24T18:29:26Z

/retest-required

Remaining retests: 0 against base HEAD bcf6c59 and 2 for PR HEAD aceef01 in total

openshift-ci · 2023-03-24T21:57:24Z

@ricky-rav: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ovn-hybrid-step-registry	`aceef01`	link	false	`/test e2e-ovn-hybrid-step-registry`
ci/prow/e2e-azure-ovn	`aceef01`	link	false	`/test e2e-azure-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ricky-rav · 2023-03-27T09:45:39Z

/retest-required

openshift-ci-robot · 2023-03-27T13:23:50Z

@ricky-rav: Jira Issue OCPBUGS-10632: All pull requests linked via external trackers have merged:

openshift/ovn-kubernetes#1569

Jira Issue OCPBUGS-10632 has been moved to the MODIFIED state.

Details

In response to this:

4.12 backport of f6ef433
Not a clean backport, because I had to account for the changes from 0111e1f, which are in 4.13 but not in 4.12.

Master, node and healthcheck code looked up the Ready field in endpoints inside endpointslices, in line with the previous implementation that dealt with the older and less fine-grained Endpoints resource, that only distinguished between ready and not ready. Healthchecks should indeed rely on the Ready field, while node and master could look up the "Serving" field, so that we won't prematurely refuse incoming connections to an endpoint that is scheduled to be terminating but is still up and running.

Making a special case for services with PublishNotReadyAddresses set, as their endpoints should always be considered ready, even if terminating. A couple of upstream kubernetes tests use this feature in 1.26.

Closes #OCPBUGS-10632

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from abhat and dcbw March 9, 2023 10:50

ricky-rav changed the title ~~[release-4.12] Check the "Serving" field for endpoints~~ [release-4.12] OCPBUGS-9912: Check the "Serving" field for endpoints Mar 9, 2023

ricky-rav force-pushed the serving_412 branch 2 times, most recently from 343e3bb to 7514f61 Compare March 14, 2023 08:31

ricky-rav force-pushed the serving_412 branch from 7514f61 to aceef01 Compare March 17, 2023 16:42

ricky-rav changed the title ~~[release-4.12] OCPBUGS-9912: Check the "Serving" field for endpoints~~ [release-4.12] OCPBUGS-10632: Check the "Serving" field for endpoints Mar 21, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 21, 2023

openshift-ci bot requested a review from anuragthehatter March 21, 2023 16:38

trozet approved these changes Mar 23, 2023

View reviewed changes

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 23, 2023

openshift-ci bot assigned anuragthehatter, asood-rh, huiran0826, jechen0648, mffiedler, qiowang721, rbbratta, weliang1, yingwang-0320 and zhaozhanqi Mar 23, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 24, 2023

openshift-merge-robot merged commit 411e730 into openshift:release-4.12 Mar 27, 2023

[release-4.12] OCPBUGS-10632: Check the "Serving" field for endpoints #1569

[release-4.12] OCPBUGS-10632: Check the "Serving" field for endpoints #1569

Uh oh!

Conversation

ricky-rav commented Mar 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Mar 9, 2023

Uh oh!

openshift-ci bot commented Mar 9, 2023

Uh oh!

openshift-ci bot commented Mar 9, 2023

Uh oh!

openshift-ci-robot commented Mar 9, 2023

Uh oh!

openshift-ci-robot commented Mar 9, 2023

Uh oh!

openshift-ci bot commented Mar 9, 2023

Uh oh!

openshift-ci bot commented Mar 9, 2023

Uh oh!

ricky-rav commented Mar 9, 2023

Uh oh!

openshift-ci-robot commented Mar 9, 2023

Uh oh!

ricky-rav commented Mar 13, 2023

Uh oh!

ricky-rav commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ricky-rav commented Mar 14, 2023

Uh oh!

ricky-rav commented Mar 14, 2023

Uh oh!

ricky-rav commented Mar 14, 2023

Uh oh!

ricky-rav commented Mar 15, 2023

Uh oh!

ricky-rav commented Mar 20, 2023

Uh oh!

openshift-ci-robot commented Mar 21, 2023

Uh oh!

openshift-ci-robot commented Mar 21, 2023

Uh oh!

openshift-ci bot commented Mar 21, 2023

Uh oh!

openshift-ci bot commented Mar 21, 2023

Uh oh!

ricky-rav commented Mar 23, 2023

Uh oh!

trozet left a comment

Choose a reason for hiding this comment

Uh oh!

trozet commented Mar 23, 2023

Uh oh!

openshift-ci bot commented Mar 23, 2023

Uh oh!

anuragthehatter commented Mar 24, 2023

Uh oh!

openshift-ci-robot commented Mar 24, 2023

Uh oh!

openshift-ci bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ricky-rav commented Mar 27, 2023

Uh oh!

openshift-ci-robot commented Mar 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

ricky-rav commented Mar 9, 2023 •

edited

Loading

ricky-rav commented Mar 14, 2023 •

edited

Loading

openshift-ci bot commented Mar 24, 2023 •

edited

Loading