Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tssurya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The nested allocator calls were propagating an error type up during an IP release. However in the bitmap allocator function it was never possible to error during an IP release. Remove the return type. Signed-off-by: Tim Rozet <trozet@redhat.com>
Changes-Include: - During pod sync we allocate IPs of all existing pods, but we should ignore completed pods - During namespace add we add all of the pod IPs to the ns address set, but we should ignore completed pods - During processing of delete event for a completed pod, we were trying to delete the pod again, which would try to free the IP that was previously released and could be in use by another pod. We should ignore delete events for completed resources as they would have been handled during update. - On node add, we add all existing pods on that node back to retry as an "add". We should skip completed pods here. - We now check during deletion of a completed pod (should happen on update only) to make sure no other running pods are using this IP as a failsafe to ensure we never release an IP in use by another pod or the related OVN config Signed-off-by: Tim Rozet <trozet@redhat.com>
Upon fetching all of the NATs on a router, if the NATs or the router dont exist this should not be an error for deletion. Signed-off-by: Tim Rozet <trozet@redhat.com>
|
@tssurya: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-ci
bot
added
the
needs-rebase
|
@tssurya: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 participants
- What this PR does and why is it needed
- Special notes for reviewers
- How to verify it
- Description for the changelog