Skip to content

[DNM] WIP merge#1067

Closed
tssurya wants to merge 7 commits intoopenshift:masterfrom
tssurya:wip-merge
Closed

[DNM] WIP merge#1067
tssurya wants to merge 7 commits intoopenshift:masterfrom
tssurya:wip-merge

Conversation

@tssurya
Copy link
Contributor

@tssurya tssurya commented May 1, 2022

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

the assumption here is that the key/cert files are pre-generated and
mounted into the ovnkube container (running either as a master or node)
and paths for these files are exposed using OVNKUBE_METRICS_PK and
OVNKUBE_METRICS_CERT environment variables

Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
@openshift-ci openshift-ci bot requested review from jcaamano and squeed May 1, 2022 13:46
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 1, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tssurya
To complete the pull request process, please assign jacobtanenbaum after the PR has been reviewed.
You can assign the PR to them by writing /assign @jacobtanenbaum in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

oribon and others added 6 commits May 2, 2022 11:04
* Add boilerplate file to fix *-gen commands: `Failed loading boilerplate: open : no such file or directory`.

Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Adding the API necessary for the EgressQoS controller
implementation as described in openshift/enhancements#1035

Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Add the EgressQoS controller as described in openshift/enhancements#1035

Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
a correctly configured noHostSubnet node will never become avalible on
GCP because the unavailable condition will never be cleared.

Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@tssurya tssurya force-pushed the wip-merge branch 2 times, most recently from c031c0c to bae8793 Compare May 2, 2022 13:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2022

@tssurya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration bae8793 link true /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
ci/prow/e2e-openstack-ovn bae8793 link false /test e2e-openstack-ovn
ci/prow/4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade bae8793 link false /test 4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration bae8793 link true /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-aws-ovn bae8793 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade bae8793 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-vsphere-ovn bae8793 link false /test e2e-vsphere-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 bae8793 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/okd-e2e-gcp-ovn bae8793 link false /test okd-e2e-gcp-ovn
ci/prow/e2e-gcp-ovn bae8793 link true /test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack bae8793 link true /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-ovn-upgrade-local-gateway bae8793 link true /test e2e-aws-ovn-upgrade-local-gateway
ci/prow/e2e-azure-ovn bae8793 link false /test e2e-azure-ovn
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade bae8793 link true /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2022

@tssurya: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tssurya tssurya closed this May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants