[DownstreamMerge] 4 -28-22 completed pods#1065
Closed
trozet wants to merge 15 commits intoopenshift:masterfrom
Closed
[DownstreamMerge] 4 -28-22 completed pods#1065trozet wants to merge 15 commits intoopenshift:masterfrom
trozet wants to merge 15 commits intoopenshift:masterfrom
Conversation
* Add boilerplate file to fix *-gen commands: `Failed loading boilerplate: open : no such file or directory`. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Adding the API necessary for the EgressQoS controller implementation as described in openshift/enhancements#1035 Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Add the EgressQoS controller as described in openshift/enhancements#1035 Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
the assumption here is that the key/cert files are pre-generated and mounted into the ovnkube container (running either as a master or node) and paths for these files are exposed using OVNKUBE_METRICS_PK and OVNKUBE_METRICS_CERT environment variables Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
a correctly configured noHostSubnet node will never become avalible on GCP because the unavailable condition will never be cleared. Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
When SBDB Chassis rows are deleted, remove the associated ChassisPrivate row as well. Remove stale ChassisPrivate rows on initial node synchronization. Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Add the EgressQoS controller
This is avoid data plane down time during ovn-controller upgrade. See ovn-org/ovn@896adfd Signed-off-by: Han Zhou <hzhou@ovn.org>
call clearInitialNodeNetworkUnavailableCondition for noHostSubnet nodes
The nested allocator calls were propagating an error type up during an IP release. However in the bitmap allocator function it was never possible to error during an IP release. Remove the return type. Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit 1a430bc)
Changes-Include: - During pod sync we allocate IPs of all existing pods, but we should ignore completed pods - During namespace add we add all of the pod IPs to the ns address set, but we should ignore completed pods - During processing of delete event for a completed pod, we were trying to delete the pod again, which would try to free the IP that was previously released and could be in use by another pod. We should ignore delete events for completed resources as they would have been handled during update. - On node add, we add all existing pods on that node back to retry as an "add". We should skip completed pods here. - We now check during deletion of a completed pod (should happen on update only) to make sure no other running pods are using this IP as a failsafe to ensure we never release an IP in use by another pod or the related OVN config Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit 7bcc8da)
Upon fetching all of the NATs on a router, if the NATs or the router dont exist this should not be an error for deletion. Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit 8ad0d79)
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: trozet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
It's happening in this merge request: |
openshift-ci
bot
added
the
needs-rebase
Contributor
|
@trozet: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
/uncc |
Contributor
|
this one can be closed in favor of #1064 ? |
Contributor
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
Contributor
|
@trozet: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
/close |
Contributor
|
@zshi-redhat: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on @zshi-redhat merge with only the completed pod fixes