Skip to content

Bug 2063245: Fix Netpol retry mechanisms#1051

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.7from
trozet:bz2063245
Jun 1, 2022
Merged

Bug 2063245: Fix Netpol retry mechanisms#1051
openshift-merge-robot merged 1 commit intoopenshift:release-4.7from
trozet:bz2063245

Conversation

@trozet
Copy link
Contributor

@trozet trozet commented Apr 25, 2022

Fix a race found with network policy and stateful sets,
an issue described in:
https://bugzilla.redhat.com/show_bug.cgi?id=2016446
ensuring we try and refetch an LSP from the cache for a pod
if the get fails or if the LSP is maked for deletion

Signed-off-by: astoycos astoycos@redhat.com
(cherry picked from commit 34f1c74)
(cherry picked from commit 8c2ad8b)
(cherry picked from commit c1d4715)

@astoycos @trozet
Fix Netpol retry mechanisms
dd20e9e 
Fix a race found with network policy and stateful sets,
an issue described in:
https://bugzilla.redhat.com/show_bug.cgi?id=2016446
ensuring we try and refetch an LSP from the cache for a pod
if the get fails or if the LSP is maked for deletion

Signed-off-by: astoycos <astoycos@redhat.com>
(cherry picked from commit 34f1c74)
(cherry picked from commit 8c2ad8b)
(cherry picked from commit c1d4715)
@trozet
Copy link
Contributor Author

trozet commented Apr 25, 2022

@astoycos PTAL

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2022

@trozet: This pull request references Bugzilla bug 2063245, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2037884 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2037884 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

Bug 2063245: Fix Netpol retry mechanisms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2022
@astoycos
Copy link
Contributor

astoycos commented Apr 25, 2022 •
edited
Loading

/lgtm

Looks like a pretty clean/isolated backport

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 25, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 25, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 25, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 25, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2022

@trozet: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@trozet
Copy link
Contributor Author

trozet commented May 16, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 16, 2022
@trozet
Copy link
Contributor Author

trozet commented May 16, 2022

/assign @anuragthehatter

@anuragthehatter
Copy link

anuragthehatter commented Jun 1, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 1, 2022
@openshift-merge-robot openshift-merge-robot merged commit febb97b into openshift:release-4.7 Jun 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

@trozet: All pull requests linked via external trackers have merged:

Bugzilla bug 2063245 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2063245: Fix Netpol retry mechanisms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@dcbw dcbw Awaiting requested review from dcbw

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas

Assignees

@astoycos astoycos

@anuragthehatter anuragthehatter

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trozet @astoycos @openshift-bot @anuragthehatter @openshift-merge-robot