[WIP] use generic watchResource with retry logic#1048
Closed
ricky-rav wants to merge 1 commit intoopenshift:masterfrom
Closed
[WIP] use generic watchResource with retry logic#1048ricky-rav wants to merge 1 commit intoopenshift:masterfrom
ricky-rav wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricky-rav The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
watchResource() incorporates the whole retry logic seen for network policies and pods and can easily be instantiated for any resource type. Applied it to pods, nodes, network policies and network policy dynamic handlers. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com> (cherry picked from commit 24a503a7c76fd4d4552a06858d03a55d4568a975)
ricky-rav
force-pushed
the
genericretrydownstream
branch
from
4b3b13f to
200eaf5
Compare
Contributor
Author
|
/retest |
Contributor
|
@ricky-rav: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[downstream PR for scale testing]
watchResource() incorporates the whole retry logic seen for network policies and pods and can easily be instantiated for any resource type.
Applied it to pods, nodes, network policies and network policy dynamic handlers.
Signed-off-by: Riccardo Ravaioli rravaiol@redhat.com
(cherry picked from commit 24a503a7c76fd4d4552a06858d03a55d4568a975)