Skip to content

Bug 2077129: [release-4.10] Fixes secondary bridge#1044

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.10from
trozet:bz2077129
May 31, 2022
Merged

Bug 2077129: [release-4.10] Fixes secondary bridge#1044
openshift-merge-robot merged 2 commits intoopenshift:release-4.10from
trozet:bz2077129

Conversation

@trozet
Copy link
Contributor

@trozet trozet commented Apr 20, 2022

No description provided.

trozet added 2 commits April 20, 2022 13:32
@trozet
Fixes creating ports for secondary bridge
3dea00b 
Migrating to libovsdb introduced a regression:
ovn-kubernetes/ovn-kubernetes#2535

Where prefix is no longer used on the switch/router ports connecting the
secondary external bridge.

Signed-off-by: Tim Rozet <trozet@redhat.com>
(cherry picked from commit be3ae73)
@trozet
Fixes secondary bridge for local gw mode
c2769f9 
There is no real difference between shared and local gateway mode for
using exgw, so enable secondary bridge exgw for local gateway too. The
limitation remains that exgw + secondary bridge requires
disable-snat-multiple gateways.

Signed-off-by: Tim Rozet <trozet@redhat.com>
(cherry picked from commit e1dd54c)
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2022

@trozet: This pull request references Bugzilla bug 2077129, which is invalid:

  • expected dependent Bugzilla bug 2028493 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2077129: [release-4.10] Fixes secondary bridge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2022 •
edited
Loading

@trozet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn c2769f9 link false /test e2e-azure-ovn
ci/prow/okd-e2e-gcp-ovn c2769f9 link false /test okd-e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@trozet
Copy link
Contributor Author

trozet commented May 16, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 16, 2022
@yprokule
Copy link

yprokule commented May 26, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

@yprokule: This pull request references Bugzilla bug 2077129, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.z) matches configured target release for branch (4.10.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2028493 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2028493 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from anuragthehatter May 26, 2022 13:26
@tssurya
Copy link
Contributor

tssurya commented May 31, 2022

/lgtm

@tssurya
Copy link
Contributor

tssurya commented May 31, 2022

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: trozet, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rbbratta
Copy link
Contributor

rbbratta commented May 31, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 31, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 31, 2022

/retest-required

Remaining retests: 2 against base HEAD 7bf36ee and 8 for PR HEAD c2769f9 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 31, 2022

/retest-required

Remaining retests: 1 against base HEAD 7bf36ee and 7 for PR HEAD c2769f9 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 31, 2022

/retest-required

Remaining retests: 0 against base HEAD 7bf36ee and 6 for PR HEAD c2769f9 in total

@openshift-merge-robot openshift-merge-robot merged commit 9495a1d into openshift:release-4.10 May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@trozet: All pull requests linked via external trackers have merged:

Bugzilla bug 2077129 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2077129: [release-4.10] Fixes secondary bridge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@tssurya tssurya Awaiting requested review from tssurya

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@tssurya tssurya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@trozet @yprokule @tssurya @rbbratta @openshift-ci-robot @openshift-merge-robot