Skip to content

[release-4.11] Bug 2108686: Greatly raise StartLimitBurst for rpm-ostreed.service #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 1 commit into from
Jul 19, 2022
Merged

[release-4.11] Bug 2108686: Greatly raise StartLimitBurst for rpm-ostreed.service #900

openshift-ci merged 1 commit into from
Jul 19, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jul 19, 2022

This is an automated cherry-pick of #898

/assign cgwalters

@cgwalters
Greatly raise StartLimitBurst for rpm-ostreed.service
caae760 
This is a hack to work around the lack of
coreos/rpm-ostree@0556152
for RHEL 8.6 and below.

A recent PR in the MCO openshift/machine-config-operator#3243
tipped things over the edge and we now see failures a lot more often.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 19, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

@openshift-cherrypick-robot: Bugzilla bug 2108320 has been cloned as Bugzilla bug 2108686. Retitling PR to link against new bug.
/retitle [release-4.11] Bug 2108686: Greatly raise StartLimitBurst for rpm-ostreed.service

Details

In response to this:

[release-4.11] Bug 2108320: Greatly raise StartLimitBurst for rpm-ostreed.service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] Bug 2108320: Greatly raise StartLimitBurst for rpm-ostreed.service [release-4.11] Bug 2108686: Greatly raise StartLimitBurst for rpm-ostreed.service Jul 19, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2108686, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2108320 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2108320 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

[release-4.11] Bug 2108686: Greatly raise StartLimitBurst for rpm-ostreed.service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member

cgwalters commented Jul 19, 2022

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022
@cgwalters
Copy link
Member

cgwalters commented Jul 19, 2022

For the record, I think:

  • The risk from this (i.e. chance to introduce new bugs) is effectively zero
  • This is very easy to test and reproduce

@sinnykumari
Copy link

sinnykumari commented Jul 19, 2022

Clean backport
/lgtm

@mrunalp mrunalp added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jul 19, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2022
@cgwalters
Copy link
Member

cgwalters commented Jul 19, 2022

/retest

@mike-nguyen
Copy link
Member

mike-nguyen commented Jul 19, 2022

/lgtm /approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, mike-nguyen, openshift-cherrypick-robot, prestist, sinnykumari, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,mike-nguyen,prestist,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 4b006db into openshift:release-4.11 Jul 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2108686 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.11] Bug 2108686: Greatly raise StartLimitBurst for rpm-ostreed.service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

travier added a commit to travier/os that referenced this pull request Jul 20, 2022
@travier
manifests: Move rpm-ostree workaround to RHEL 8 only
20ab24a 
See: openshift#900
Fixes: openshift@caae760
travier added a commit to travier/os that referenced this pull request Jul 20, 2022
@travier
manifests: Move rpm-ostree workaround to RHEL 8 only
aa98251 
See: openshift#900
Fixes: openshift@caae760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@travier travier travier approved these changes

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

+1 more reviewer

@prestist prestist prestist approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cgwalters cgwalters

@sinnykumari sinnykumari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @cgwalters @sinnykumari @mike-nguyen @prestist @travier @mrunalp