Skip to content

Conversation

@cgwalters
Copy link
Member

@openshift-ci openshift-ci bot requested review from HuijingHei and marmijo July 11, 2022 20:49
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
@HuijingHei
Copy link
Contributor

/retest

@travier
Copy link
Member

travier commented Jul 12, 2022

Pushed #890 which includes a temporary hack to test the change.

@cgwalters
Copy link
Member Author

/retest

@travier
Copy link
Member

travier commented Jul 12, 2022

Note that nothing here tests this change thus why I did the hack in #890

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2022

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@travier
Copy link
Member

travier commented Jul 12, 2022

/close
Closing in favor of #891 until we test things more.

@cgwalters
Copy link
Member Author

okay, but wouldn't you say this change is still obviously correct?

@openshift-ci openshift-ci bot closed this Jul 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2022

@travier: Closed this PR.

Details

In response to this:

/close
Closing in favor of #891 until we test things more.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants