Skip to content

Conversation

@mike-nguyen
Copy link
Member

Add test to verify that rhaos package versions match the OpenShift
version.

Add test to verify that rhaos package versions match the OpenShift
version.
@openshift-ci openshift-ci bot requested review from dustymabe and jlebon September 23, 2021 16:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2021
@miabbott
Copy link
Member

miabbott commented Sep 23, 2021

Sep 23 17:52:47 qemu0 kola-runext-misc-ro.sh[1600]: + [[ -n cri-o-1.21.3-2.rhaos4.8.gitff0b7fe.el8.x86_64 ]]
Sep 23 17:52:47 qemu0 kola-runext-misc-ro.sh[1600]: + fatal 'Error: rhaos packages do not match OpenShift version'
Sep 23 17:52:47 qemu0 kola-runext-misc-ro.sh[1600]: + echo 'Error: rhaos packages do not match OpenShift version'

Already providing value! cri-o should be 1.22 for OCP 4.10

@miabbott
Copy link
Member

cri-o-1.22.0-67.rhaos4.10.git6becad2 landed in the downstream plashets; let's see if it is on the mirrors

/retest

@cgwalters
Copy link
Member

cgwalters commented Sep 24, 2021

This also seems like something again we could enforce at build time, actually it's really something ART should probably be enforcing on their side I think. That all said, clearly this is still a simple check, so it makes sense to me to ship. Thanks for doing this!

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants