Skip to content

Conversation

@cgwalters
Copy link
Member

Turns out the image-format: oci change broke the rhcos upgrade
test, let's add coverage of that.

While we have the patient open, also run all kola tests.

@openshift-ci openshift-ci bot requested review from bgilbert and dustymabe September 1, 2021 15:07
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2021
@cgwalters
Copy link
Member Author

Cool, this correctly failed:

 --- FAIL: rhcos.upgrade.luks/setup (16.66s)
cluster.go:143: error: opening repo: opendir(objects): No such file or directory 

And then once #613 merges we can rebase this and verify it passes.

Turns out the `image-format: oci` change broke the rhcos upgrade
test, let's add coverage of that.

While we have the patient open, also run all kola tests.
Copy link
Member

@miabbott miabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, miabbott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5802f48 into openshift:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants