Skip to content

rhcos-fde: tpm2_pcrlist is now tpm2_pcrread#511

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
miabbott:tpm2_fixes
Mar 9, 2021
Merged

rhcos-fde: tpm2_pcrlist is now tpm2_pcrread#511
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
miabbott:tpm2_fixes

Conversation

@miabbott
Copy link
Member

@miabbott miabbott commented Mar 8, 2021

Happened to see this error while building RHCOS:

dracut-install: ERROR: installing 'tpm2_pcrlist'
dracut: FAILED: /usr/lib/dracut/dracut-install -D /tmp/dracut/dracut.ibNvrR/initramfs -a -f blockdev base64 chmod clevis clevis-decrypt clevis-decrypt-sss clevis-decrypt-tpm2 clevis-encrypt-sss clevis-encrypt-tang clevis-encrypt-tpm2 clevis-luks-bind clevis-luks-common-functions clevis-luks-unbind clevis-luks-unlock cryptsetup cryptsetup-reencrypt curl cut dd dirname growpart head jose jq luksmeta mktemp nc pwmake sfdisk sync systemd-detect-virt touch tpm2_create tpm2_createpolicy tpm2_createprimary tpm2_load tpm2_pcrlist tpm2_unseal tr umount

Found https://bugzilla.redhat.com/show_bug.cgi?id=1847983 which states
that tpm2_pcrlist has been renamed to tpm2_pcrread

Happened to see this error while building RHCOS:

```
dracut-install: ERROR: installing 'tpm2_pcrlist'
dracut: FAILED: /usr/lib/dracut/dracut-install -D /tmp/dracut/dracut.ibNvrR/initramfs -a -f blockdev base64 chmod clevis clevis-decrypt clevis-decrypt-sss clevis-decrypt-tpm2 clevis-encrypt-sss clevis-encrypt-tang clevis-encrypt-tpm2 clevis-luks-bind clevis-luks-common-functions clevis-luks-unbind clevis-luks-unlock cryptsetup cryptsetup-reencrypt curl cut dd dirname growpart head jose jq luksmeta mktemp nc pwmake sfdisk sync systemd-detect-virt touch tpm2_create tpm2_createpolicy tpm2_createprimary tpm2_load tpm2_pcrlist tpm2_unseal tr umount
```

Found https://bugzilla.redhat.com/show_bug.cgi?id=1847983 which states
that `tpm2_pcrlist` has been renamed to `tpm2_pcrread`
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2021
@miabbott miabbott changed the title rhcos-fde: tmp2_pcrlist is now tmp2_pcrread rhcos-fde: tpm2_pcrlist is now tpm2_pcrread Mar 8, 2021
@miabbott miabbott requested review from jlebon and removed request for dustymabe March 8, 2021 21:35
@miabbott
Copy link
Member Author

miabbott commented Mar 8, 2021

The name change was part of RHEL 8.3, so that means RHCOS 4.7 has this problem. Though I don't know if failure to install that module is actually affecting anything right now.

@jlebon
Copy link
Member

jlebon commented Mar 8, 2021

A lot of this stuff can be dropped now that we've moved to LUKS via Ignition, where we rely on Clevis to know what binaries it needs to install (see review comments in coreos/ignition-dracut#192), but meh... I guess it's safer to just stick with this for now until we completely drop it.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, jlebon, miabbott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ashcrow,jlebon,miabbott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@ashcrow
Copy link
Member

ashcrow commented Mar 9, 2021

 + cosa fetch
fatal: Missing /dev/kvm
error: build error: error building at STEP "RUN /bin/bash -c set -o errexit; umask 0002; ./ci/build-test.sh": error while running runtime: exit status 1 

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@miabbott
Copy link
Member Author

miabbott commented Mar 9, 2021

 + cosa fetch
fatal: Missing /dev/kvm
error: build error: error building at STEP "RUN /bin/bash -c set -o errexit; umask 0002; ./ci/build-test.sh": error while running runtime: exit status 1 

More of #506

I'm going to override the test result; I've build this locally and done cosa kola run successfully

/override ci/prow/unit

@openshift-ci-robot
Copy link

@miabbott: Overrode contexts on behalf of miabbott: ci/prow/unit

Details

In response to this:

 + cosa fetch
fatal: Missing /dev/kvm
error: build error: error building at STEP "RUN /bin/bash -c set -o errexit; umask 0002; ./ci/build-test.sh": error while running runtime: exit status 1 

More of #506

I'm going to override the test result; I've build this locally and done cosa kola run successfully

/override ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit f413417 into openshift:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants