Skip to content

Conversation

@yuqi-zhang
Copy link
Contributor

After giving launch permissions for the newest ami, also push
the json file with the ami-id to a public s3 bucket.

Signed-off-by: Yu Qi Zhang [email protected]

After giving launch permissions for the newest ami, also push
the json file with the ami-id to a public s3 bucket.

Signed-off-by: Yu Qi Zhang <[email protected]>
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2018
@yuqi-zhang
Copy link
Contributor Author

yuqi-zhang commented Sep 25, 2018

Tested. Example pipeline: https://continuous-infra-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/rhcos/job/jerzhang-test-coreos-rhcos-cloud/

The bucket name is called rhcos-public as none of the stakeholders really minded what the name would be.

@yuqi-zhang
Copy link
Contributor Author

/retest

Copy link
Member

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will let @miabbott pull the merge lever if he also 👍's.

@cgwalters
Copy link
Member

/assign miabbott

But LGTM too

@yuqi-zhang
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2018
@yuqi-zhang
Copy link
Contributor Author

yuqi-zhang commented Sep 25, 2018

/hold cancel

@yuqi-zhang
Copy link
Contributor Author

Now that we merged: #315 I think we're ok regarding bits?

@yuqi-zhang
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2018
@miabbott
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2018
@openshift-merge-robot openshift-merge-robot merged commit 5da1126 into openshift:master Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants