Skip to content

Drop docker from compose #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Sep 12, 2018
Merged

Drop docker from compose #283

openshift-merge-robot merged 2 commits into from
Sep 12, 2018

Conversation

@ashcrow
Copy link
Member

@ashcrow ashcrow commented Sep 11, 2018 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2018
@ashcrow
Copy link
Member Author

ashcrow commented Sep 11, 2018

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2018
@ashcrow ashcrow changed the title host-maipo.yaml: Drop docker from compose Drop docker from compose Sep 11, 2018
@ashcrow
Copy link
Member Author

ashcrow commented Sep 12, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2018
@ashcrow
Copy link
Member Author

ashcrow commented Sep 12, 2018

Required PRs have been merged. PTAL.

@jlebon
Copy link
Member

jlebon commented Sep 12, 2018

That's awesome!
To confirm, this will break oc cluster up for now, right?

@ashcrow
Copy link
Member Author

ashcrow commented Sep 12, 2018

@jlebon from my understanding, yes. It also will break other systems which previously hard assumed docker was the only container runtime available.

@cgwalters
Copy link
Member

cgwalters commented Sep 12, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2018
@openshift-merge-robot openshift-merge-robot merged commit 30495ee into openshift:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@cgwalters cgwalters Awaiting requested review from cgwalters

@crawford crawford Awaiting requested review from crawford

@dm0- dm0- Awaiting requested review from dm0-

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@cgwalters cgwalters

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ashcrow @jlebon @cgwalters @openshift-ci-robot @openshift-merge-robot