Skip to content

COS-1935: overlay: include 40grub overlay from FCOS configs#1413

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
dustymabe:dusty-grub-overlay
Jan 5, 2024
Merged

COS-1935: overlay: include 40grub overlay from FCOS configs#1413
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
dustymabe:dusty-grub-overlay

Conversation

@dustymabe
Copy link
Copy Markdown
Member

See coreos/fedora-coreos-config#2769

This won't really have any effect right now but will enable someone to use the generated ociarchive container images in the OSBuild workflow that calls bootupctl with the --with-static-configs argument.

See coreos/fedora-coreos-config#2769

This won't really have any effect right now but will enable someone
to use the generated ociarchive container images in the OSBuild
workflow that calls bootupctl with the --with-static-configs argument.
@openshift-ci openshift-ci bot requested review from cverna and gursewak1997 January 5, 2024 04:47
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 5, 2024

@dustymabe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmarrero
Copy link
Copy Markdown
Member

jmarrero commented Jan 5, 2024

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jmarrero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dustymabe dustymabe changed the title overlay: include 40grub overlay from FCOS configs COS-1935: overlay: include 40grub overlay from FCOS configs Jan 5, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 5, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 5, 2024

@dustymabe: This pull request references COS-1935 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.15" instead.

Details

In response to this:

See coreos/fedora-coreos-config#2769

This won't really have any effect right now but will enable someone to use the generated ociarchive container images in the OSBuild workflow that calls bootupctl with the --with-static-configs argument.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 5e5f601 into openshift:master Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants