Skip to content

[release-4.13] ext.config.shared.systemd.default-unit-timeouts failing #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Adam0Brien wants to merge 1 commit into from
Closed

[release-4.13] ext.config.shared.systemd.default-unit-timeouts failing #1205

Adam0Brien wants to merge 1 commit into from

Conversation

@Adam0Brien
Copy link
Contributor

@Adam0Brien Adam0Brien commented Mar 16, 2023

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2023
travier
travier reviewed Mar 16, 2023
View reviewed changes
@Adam0Brien Adam0Brien changed the title [4.13] ext.config.shared.systemd.default-unit-timeouts failing [release-4.13] ext.config.shared.systemd.default-unit-timeouts failing Mar 16, 2023
@travier travier mentioned this pull request Mar 16, 2023
Merged
@Adam0Brien Adam0Brien changed the base branch from master to release-4.13 March 16, 2023 16:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2023

@Adam0Brien: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13] ext.config.shared.systemd.default-unit-timeouts failing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2023
@Adam0Brien Adam0Brien changed the base branch from release-4.13 to master March 16, 2023 16:23
@Adam0Brien Adam0Brien changed the base branch from master to release-4.13 March 16, 2023 16:24
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2023

@Adam0Brien: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13] ext.config.shared.systemd.default-unit-timeouts failing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Adam0Brien Adam0Brien force-pushed the skip-systemd-unit-test branch from fc2dd59 to 094ea82 Compare March 16, 2023 17:05
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2023
@travier
Copy link
Member

travier commented Mar 17, 2023

/lgtm

@travier
Copy link
Member

travier commented Mar 17, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 17, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
dustymabe
dustymabe approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@HuijingHei
Copy link
Contributor

HuijingHei commented Mar 21, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adam0Brien, dustymabe, HuijingHei, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Adam0Brien,HuijingHei,dustymabe,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travier
Copy link
Member

travier commented Apr 4, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 4, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2023
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Apr 4, 2023

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Apr 4, 2023

/label bugzilla/valid-bug
/label jira/valid-bug

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 4, 2023
@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 4, 2023
@mike-nguyen
Copy link
Member

mike-nguyen commented Apr 11, 2023

@Adam0Brien we are no longer using RHEL 8.6 on 4.13. Do you want to just close out this PR?

@Adam0Brien
Copy link
Contributor Author

Adam0Brien commented Apr 11, 2023

@Adam0Brien we are no longer using RHEL 8.6 on 4.13. Do you want to just close out this PR?

sure thanks for letting me know!

@Adam0Brien Adam0Brien closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@travier travier travier left review comments

@dustymabe dustymabe dustymabe approved these changes

@RishabhSaini RishabhSaini Awaiting requested review from RishabhSaini

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

Assignees

@dustymabe dustymabe

@travier travier

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Adam0Brien @travier @HuijingHei @openshift-merge-robot @sdodson @mike-nguyen @dustymabe