Add image-c9s.yaml #1124
Add image-c9s.yaml #1124
Conversation
Adds a dedicated image config for CentOS Stream 9. `oc adm release new` and the CVO require the `machine-os` label to be present on one of the payload images. For c9s, we let COSA add the required labels to the ostree container image. In OKD/SCOS, this image is aliased as both `machine-os-content` and `centos-stream-coreos-9` in the payload.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, LorbusChris The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
Have we fixed the issue from #1084 ? |
|
Hmm right no we haven't...this will actually break the current plan to use C9S for OCP temporarily because we haven't aliased Ugh so this all starts to pile up onto digging out of the DTK hole i.e. openshift/driver-toolkit#102 and openshift/driver-toolkit#103 and https://issues.redhat.com/browse/MCO-392 |
|
OK well I guess for now we could change the OKD pipeline to do this. |
|
@cgwalters afaik DTK in OKD does work with the Can't OCP 4.13 just stop shipping the legacy container, and start putting the labels on the ostree container, and alias the |
|
Carrying this downstream would be OK for now, too. |
Ummm....I don't know 😄 I would personally certainly be very happy if we do that... |
|
OK, once we have #1127, we should be able to merge this one and have SCOS be SCOS again. |
|
@travier @cgwalters #1127 has merged, do you think we can unhold and merge this one now? |
|
LGTM |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@LorbusChris: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
Adds a dedicated image config for CentOS Stream 9.
oc adm release newand the CVO require themachine-oslabel to be present on one of the payload images.For c9s, we let COSA add the required labels to the ostree container image.
In OKD/SCOS, this image is aliased as both
machine-os-contentandcentos-stream-coreos-9in the payload.