Skip to content

Support namespace in path for requesting k8s api from web console #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-bot merged 1 commit into from
Feb 12, 2015
Merged

Support namespace in path for requesting k8s api from web console #986

openshift-bot merged 1 commit into from
Feb 12, 2015

Conversation

@jwforres
Copy link
Member

@jwforres jwforres commented Feb 11, 2015

No description provided.

@jwforres jwforres changed the title Support namespace in path for requesting k8s api from web console [WIP] Support namespace in path for requesting k8s api from web console Feb 11, 2015
@jwforres
Copy link
Member Author

jwforres commented Feb 11, 2015

@liggitt review

v1beta3 k8s api was not supposed to be allowing namespace as a query param anymore. After the next rebase it may no longer work. osapi does not yet support namespace in path. So for now we have to handle namespace in two different ways depending on which api we are pointing to and whether we are building a URL that includes a namespace or not.

@deads2k @ncdc when you guys do the next rebase, the only change you will need to make in the console after this is to switch the URL templates at the bottom of service/data.js from /ns/{namespace}/ to /namespaces/{namespace}/ (and rebuild bindata.go)

liggitt
liggitt reviewed Feb 11, 2015
View reviewed changes
assets/app/scripts/services/data.js Outdated
Copy link
Contributor

@liggitt liggitt Feb 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete?

Copy link
Contributor

@liggitt liggitt Feb 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to worry about mutating params? Not sure what calls this and if it expects namespace to be unset on the params object it passes in

Copy link
Contributor

@liggitt liggitt Feb 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's safe to mutate (based on our usage of _urlForType), but I'd still prefer we do

params = angular.copy(params);
delete params.namespace;

@jwforres jwforres changed the title [WIP] Support namespace in path for requesting k8s api from web console Support namespace in path for requesting k8s api from web console Feb 12, 2015
@jwforres
Copy link
Member Author

jwforres commented Feb 12, 2015

@liggitt updated with review feedback and bindata generated

@liggitt
Copy link
Contributor

liggitt commented Feb 12, 2015

LGTM

@jwforres
Copy link
Member Author

jwforres commented Feb 12, 2015

[merge]

@jwforres jwforres added this to the 0.4.0 (beta2) milestone Feb 12, 2015
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 12, 2015

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/897/) (Image: devenv-fedora_771)

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 12, 2015

Evaluated for origin up to db46929

openshift-bot pushed a commit that referenced this pull request Feb 12, 2015
Merge pull request #986 from jwforres/namespace_in_path
3317c7b 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 3317c7b into openshift:master Feb 12, 2015
@jwforres jwforres deleted the namespace_in_path branch March 19, 2015 20:03
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Aug 10, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
099429c 
…service-catalog/' changes from 568a7b9..8f07b7b

8f07b7b origin: add required patches
ee57bfb Cleanup of ups broker example + making controller follow the OSB API (openshift#807)
45a11ed Revert "Rename our resources to have ServiceCatalog prefix (openshift#1054)" (openshift#1061)
4e47ec1 Rename our resources to have ServiceCatalog prefix (openshift#1054)
2bb334a Rebase on 1.7 API machinery (openshift#944)
5780b59 Run broker reconciler when spec is changed. (openshift#1026)
9c22d04 Merge branch 'pr/1006'
d077915 check number of expected events before dereferencing to avoid panic (openshift#1052)
90d615f Merge branch 'pr/1055'
bb6d6d8 fix log output to use formatted output (openshift#1056)
c7abc81 Adding examples to the README
ccc93c9 Remove different-org rule for LGTM (openshift#1050)
be04cd5 Allow for a period in the GUID of the External ID (openshift#1034)
8c246df Make it so that binding.spec.secretName defaults to binding name (openshift#851)
6745418 Bump OSB Client (openshift#1049)
8346a0d apiserver etcd healthcheck as suggested to address k/k#48215 (openshift#1039)
11d0d4a use GKE's latest 1.6.X cluster version for Jenkins (openshift#1036)
7d71b5b Cross-build all the things!
8ec0874 RBAC setup behind the aggregator. (openshift#936)
0864a2e Upsert retry loop for Secret, set/check ownerReference for Secret owned by Binding (openshift#979)
6be9886 add info about weekly calls (openshift#1027)
a242b26 add OSB API Header version flag (openshift#1014)
66e2ce6 Update REVIEWING doc with changes to LGTM process (openshift#1016)
699e016 Writing the returned progress description from the broker (openshift#998)
02642f4 Adding target to test on the host (openshift#1020)
78ca572 v0.0.13 (openshift#1024)
9e79ec2 use GKE's default K8S version for Jenkins (openshift#1023)
d3c915a Fix curl on API server start error (openshift#1015)
b50be75 Merge branch 'pr/1013'
2c98ba1 Using tag URLs
687f091 Parameterizing the priority fields
34ed5cd update apiregistration yaml to v1.7 final (openshift#1011)
91fa1ad make e2e look for pods' existence before checking status (openshift#1012)
0f90705 explicitly disable leader election if it is not enabled (openshift#965)
f5761e7 controller-manager health checks (openshift#694)
da260f2 Add logging for normal Unbind errors (openshift#992)
4c916a5 make the apiserver test use tls (openshift#991)
1a62ecc refactor reconcileBroker (openshift#986)
cc179bc Add logging for normal Bind errors (openshift#993)
a1458dd add parameterization for user-broker image to e2e tests (openshift#995)
fb15891 Bump OSB client (openshift#1000)
79d5206 v0.0.12 (openshift#996)
39c7407 Merge branch 'pr/975'
a553b2d Merge branch 'pr/974'
d573339 reconcileBinding error checking (openshift#973)
39a1061 Making events and actions checks generic (openshift#960)
73136a4 Bump osb client (openshift#971)
878a987 reconcileInstance error checking in unit-tests
4991d57  reconcileBroker error checking in unit-tests
9ed6812 Extract methods for binding test setup (openshift#961)
b69a1ee Make ups-broker return valid unbind response (openshift#964)
8b37d2f Releasing 0.0.11 (openshift#962)
52fec8b Merge branch 'pr/954'
d49cdeb Swap client
445fa71 Add dependency on pmorie/go-open-service-broker-client
9f743b2 Instructions for enabling API Aggregation (openshift#895)
512508d Use correct infof calls in controller_manager (openshift#950)
77943ba fix regex that determines if a tag is deployable (openshift#947)
8a226b8 Updates for v0.0.10 release (openshift#943)
REVERT: 568a7b9 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: 8f07b7bbf3acb2b557f23596a92b5e775ae9321c
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018
@MHBauer @kibbles-n-bytes
refactor reconcileBroker (openshift#986)
1a62ecc 
- moving the client setup to the scope in which it is used cleans up
   the scoping and provides a view of three main blocks.
     - 1 Whether to do anything at all
     - 2 Add or Update
     - 3 Finalizers and deletion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.4.0 (beta2)

Development

Successfully merging this pull request may close these issues.

3 participants

@jwforres @liggitt @openshift-bot