Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor stable layer count unit test to get rid of flake #9801

Merged
merged 1 commit into from
Jul 13, 2016
Merged

Refactor stable layer count unit test to get rid of flake #9801

merged 1 commit into from
Jul 13, 2016

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Jul 12, 2016 •
edited
Loading

Removes unpredictability due to concurrency in unit test. Now only tests the specific function.

Fixes #9759

@csrwng
Copy link
Contributor Author

csrwng commented Jul 12, 2016

@bparees ptal

@bparees
Copy link
Contributor

bparees commented Jul 12, 2016

lgtm [merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@csrwng
Copy link
Contributor Author

csrwng commented Jul 12, 2016

test failure hit flake #9804

@csrwng
Copy link
Contributor Author

csrwng commented Jul 12, 2016

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 8d90d09

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6160/)

@bparees
Copy link
Contributor

bparees commented Jul 13, 2016

flake.
[merge]

@bparees
Copy link
Contributor

bparees commented Jul 13, 2016

@csrwng you are cursed.

flake #9681

[merge]

@bparees
Copy link
Contributor

bparees commented Jul 13, 2016

flake #9195
[merge]

@bparees
Copy link
Contributor

bparees commented Jul 13, 2016

[merge]

@bparees
Copy link
Contributor

bparees commented Jul 13, 2016

wow.
[merge]

@bparees
Copy link
Contributor

bparees commented Jul 13, 2016

flake #9195
[merge]

@bparees
Copy link
Contributor

bparees commented Jul 13, 2016

flake #9548
#9548
[merge]

On Wed, Jul 13, 2016 at 2:50 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6210/)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9801 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEvl3hI268Wd5JmM2nrS73nmsUNymzExks5qVTOGgaJpZM4JKduf
.

Ben Parees | OpenShift

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 8d90d09

@openshift-bot openshift-bot merged commit f7a01f8 into openshift:master Jul 13, 2016
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6216/)

@csrwng
Copy link
Contributor Author

csrwng commented Jul 13, 2016

\o/

@csrwng csrwng deleted the stablelayercount_flake branch July 19, 2016 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csrwng @bparees @openshift-bot