Removed environment variable substitution step from stacktrace #9704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] me |
An unintended consequence of attempting to substitute envars in the stacktrace was that subshell literals would be eval- uated as well, which is surprising in that a stacktrace should not be excecuting arbitrary code and incorrect in that any non-reentrant code when executed by the stacktrace would lead to errors elsewhere. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/disable-env-subs-only
branch
from
4b78b93 to
3caac43
Compare
|
Evaluated for origin test up to 3caac43 |
|
[merge] |
|
Evaluated for origin merge up to 3caac43 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5786/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5791/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unintended consequence of attempting to substitute envars
in the stacktrace was that subshell literals would be eval-
uated as well, which is surprising in that a stacktrace should
not be excecuting arbitrary code and incorrect in that any
non-reentrant code when executed by the stacktrace would lead
to errors elsewhere.
@bparees PTAL -- this is the single commit for removing the
evalFixes #9512
Fixes #9685