Package up install-router.sh for inclusion in RPMs

[sdodson]

This is temporary. If we're looking for this to be a complete solution for OSE we'll also need to modify the image name.

[sdodson]

@pweil- and @sosiouxme relevant to your interests

[sosiouxme]

Need the same thing for the docker registry (so it can alert the master when it gets updated images).

https://github.com/openshift/origin/blob/master/hack/install-registry.sh

[pweil-]

I'm starting to think we should just convert this to use getopts. The next person that has another file/cert/whatever is going to run into the same trouble but hack/install-router -r ~/route.json -c ~/thecert.pem -i routerId -m https://masterurl:8443 seems like a decent solution.

What do you think @sosiouxme @thoraxe @sdodson?

[thoraxe]

It would be nice if you could specify files and other things on the cli, and have the script automatically ingest them and turn them into appropriate vars.

[sdodson]

I was going to suggest that we convert pod.json into a template similar to how install-registry.sh and examples/sample-app/docker-registry-template.json do things. But I found out that template parameters are only evaluated for environment variables so this won't work for adjusting the image name from 'openshift/docker-registry' to 'openshift3_beta/docker-registry' so we're stuck with sed manipulation regardless.

We could just keep adding things to /etc/sysconfig/openshift and have scripts source that file if it exists and has the variable we want otherwise use script local defaults. This may be nice because it would promote re-use, i hope, perhaps not in practice.

[openshift-bot]

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

[smarterclayton]

#1053 removes the need for this pull. Router installation is a separate command, and hack/install-router is gone.

[detiber]

#1043 Is the correct PR for the router command