project clusterresourcequota into applicable namespaces #9609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
deads2k
force-pushed
the
cq-06-projection
branch
2 times, most recently
from
3899fdf to
385ab68
Compare
openshift-bot
added
the
needs-rebase
| list := "aapi.ClusterResourceQuotaList{} | ||
| matcher := clusterresourcequotaregistry.Matcher(oapi.ListOptionsToSelectors(options)) | ||
| quotaNames, _ := r.quotaMapper.GetClusterQuotasFor(namespace) | ||
| fmt.Printf("#### 10a quotaNames: %v\n", quotaNames) |
|
One debug leftover, otherwise LGTM. |
|
other alternatives considered:
appliedclusterresourcequotas seems the best of the bunch |
deads2k
force-pushed
the
cq-06-projection
branch
from
385ab68 to
44679f9
Compare
|
[merge] |
openshift-bot
removed
the
needs-rebase
deads2k
force-pushed
the
cq-06-projection
branch
5 times, most recently
from
f111cd2 to
1198a6f
Compare
|
Add a better description to the object godoc, including how it is used |
done. |
|
Impeccable. |
|
re[test] |
|
#9512 re[test] |
|
Evaluated for origin test up to dfc40a7 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5703/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5737/) (Image: devenv-rhel7_4512) |
|
Evaluated for origin merge up to dfc40a7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last commit only. Builds on #9558 and #9588.
Adds
appliedclusterresourcequotasas a projection ofclusterresourcequotasthat apply@openshift/api-review Let's sort out name. Other possibilities that came up: applicableclusterresourcequota (jessica didn't care for it), associatedclusterresourcequota (doesn't seem any better)