Make images/pod buildable on Mac OS X #907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I sunk a few hours into this last night. Just making it buildable isn't enough: the binary isn't included in the release tar, so if you don't do more work, the darwin binary goes into the images via build-images.sh, which is bad. Here's the fix I proposed: #897 |
Contributor
|
My work was based on Clayton's statement that he didn't want the pod binary in the release tar (if the binary were in the tar, the work becomes much simpler). |
Contributor
Author
|
@ironcladlou thx, I'll close this PR. |
sjenning
pushed a commit
to sjenning/origin
that referenced
this pull request
Jan 5, 2018
UPSTREAM: 48613: proxy/userspace: honor listen IP address as host IP if given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hack/build-images.sh is broken on Mac. There's no reason to restrict images/pod/pod.go to only build on linux.