oc rollout support #8927

0xmichalis · 2016-05-18T18:06:03Z

TODO:

Fixes #6896
Part of https://trello.com/c/Mljldox7/643-5-deployments-downstream-support-for-upstream-features

@fabianofranz @ironcladlou @mfojtik @smarterclayton

0xmichalis · 2016-05-18T22:37:00Z

@smarterclayton @fabianofranz thoughts on:
oc rollout instantiate maps to oc deploy --latest
oc rollout undo maps to oc rollback
I don't want to have oc rollout retry before we decide upstream what do do with it. For me, it makes sense to have just oc rollout instantiate for both actions.
Still thinking about oc rollout latest deploying the latest existing image but I am not sure how this should happen atm or if it should happen at all (without an ICT)

smarterclayton · 2016-05-19T02:28:04Z

The one thing I'm not clear on is triggers. Do we want to implement Pause
first, so that rollout undo can correctly pause the deployment?

On Wed, May 18, 2016 at 6:37 PM, Michail Kargakis [email protected]
wrote:

@smarterclayton https://github.com/smarterclayton @fabianofranz
https://github.com/fabianofranz thoughts on:
oc rollout instantiate maps to oc deploy --latest
oc rollout undo maps to oc rollback
I don't want to have oc rollout retry before we decide upstream what do
do with it. For me, it makes sense to have just oc rollout instantiate
for both actions.
Still thinking about oc rollout latest deploying the latest existing
image but I am not sure how this should happen atm or if it should happen
at all (without an ICT)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8927 (comment)

0xmichalis · 2016-05-19T12:20:23Z

@smarterclayton what is the difference between Pause and a config change trigger?

smarterclayton · 2016-05-24T18:57:23Z

Pause stops all processing (all triggers, and probably scaling behavior). Config change trigger just stops config change.

0xmichalis · 2016-05-24T19:27:45Z

probably scaling behavior

We are working upstream on enabling this with proportional scaling (scaling isn't supported in the first version of paused). A paused deployment is still a running application and autoscalers should be able to continue working.

0xmichalis · 2016-06-10T15:32:17Z

cc: @fabianofranz @mfojtik @ironcladlou @smarterclayton

oc rollout pause, resume, and history are ready for review.

Sample output for oc rollout histroy:

$ oc rollout history dc/frontend
deploymentconfigs "frontend" history viewed
REVISION    STATUS      CAUSE
1       Complete    caused by a config change
2       Complete    caused by an image change
3       Complete    caused by an image change
4       Failed      cancelled by the user
5       Failed      cancelled as a newer deployment was found running
6       Complete    caused by a config change

Outstanding issue with history: we need to surface deployments triggered manually into the deployment status. The best way to do this is a /instantiate endpoint. Currently oc deploy --latest will return the same cause as the one the deployment config had before the redeployment.

Separate pulls:

I will add oc rollout undo either in Rollback rework #9135 if the present pull merges first or in a follow up to this if Rollback rework #9135 merges first.
oc rollout status once the rebase lands
Move oc deploy to oc rollout in a separate pull, will open issue for this.

0xmichalis · 2016-06-10T16:19:53Z

[test]

0xmichalis · 2016-06-10T16:38:23Z

Outstanding issue with history: we need to surface deployments triggered manually into the deployment status. The best way to do this is a /instantiate endpoint. Currently oc deploy --latest will return the same cause as the one the deployment config had before the redeployment.

Related: #4359

0xmichalis · 2016-06-13T11:33:41Z

Move oc deploy to oc rollout in a separate pull, will open issue for this.

#9298

0xmichalis · 2016-06-23T09:34:04Z

[test]

smarterclayton · 2016-06-23T15:04:39Z

pkg/deploy/controller/generictrigger/controller.go

+	case deployapi.DeploymentTriggerOnConfigChange:
+		config.Status.Details.Message = "caused by a config change"
+	case deployapi.DeploymentTriggerOnImageChange:
+		config.Status.Details.Message = "caused by an image change"


Messages probably should be sentences (or be capitalized). It's fine for now but we should revisit

I am merely consistent with our pre-existing messages surfaced by our annotations:

origin/pkg/deploy/api/types.go

Lines 262 to 265 in 16bcdd0

DeploymentCancelledByUser = "cancelled by the user"

DeploymentCancelledNewerDeploymentExists = "cancelled as a newer deployment was found running"

DeploymentFailedUnrelatedDeploymentExists = "unrelated pod with the same name as this deployment is already running"

DeploymentFailedDeployerPodNoLongerExists = "deployer pod no longer exists"

0xmichalis · 2016-06-29T12:35:37Z

Somebody needs to start reviewing this @mfojtik @fabianofranz @ironcladlou @smarterclayton

mfojtik · 2016-06-29T13:38:58Z

pkg/cmd/util/clientcmd/factory.go

+			}
+			t.Spec.Paused = true
+			_, err := oc.DeploymentConfigs(t.Namespace).Update(t)
+			// TODO: Pause the deployer containers.


is there issue created to track this?

Opened #9629

mfojtik · 2016-06-29T13:42:58Z

pkg/deploy/cmd/rollback.go

+
+var _ kubectl.Rollbacker = &DeploymentConfigRollbacker{}
+
+func (r *DeploymentConfigRollbacker) Rollback(namespace, name string, updatedAnnotations map[string]string, toRevision int64, obj runtime.Object) (string, error) {


mfojtik · 2016-06-29T15:21:37Z

LGTM

0xmichalis · 2016-06-29T15:49:13Z

Opened #9632 that will be needed once this is merged.

0xmichalis · 2016-06-29T20:23:40Z

[merge]

ChangeCauseAnnotation is hardcoded in PrintRolloutHistory and it needs to be overriden since other resources that may need to be added in `kubectl rollout history` may not use it. Instead of adding one more method in the factory, refactor the existing HistoryViewer interface to accomodate the change.

openshift-bot · 2016-06-30T09:45:44Z

Evaluated for origin test up to d362664

openshift-bot · 2016-06-30T11:10:34Z

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5602/)

0xmichalis · 2016-07-01T08:45:17Z

conformance never run, [merge]

0xmichalis · 2016-07-01T10:11:01Z

Flaked on #9364. [merge]

openshift-bot · 2016-07-01T11:40:27Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5669/) (Image: devenv-rhel7_4500)

0xmichalis · 2016-07-01T11:42:29Z

#9512, [merge]

openshift-bot · 2016-07-01T11:45:26Z

Evaluated for origin merge up to d362664

0xmichalis added component/cli priority/P2 component/apps labels May 18, 2016

0xmichalis assigned mfojtik May 18, 2016

0xmichalis mentioned this pull request May 21, 2016

Deployment rollback dry-run could show a diff of old/new #3652

Closed

0xmichalis mentioned this pull request May 30, 2016

Add pausing in deploymentconfigs #9086

Merged

0xmichalis changed the title ~~[WIP] oc rollout support~~ oc rollout support Jun 10, 2016

0xmichalis mentioned this pull request Jun 13, 2016

Move oc deploy in oc rollout #9298

Closed

openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 16, 2016

0xmichalis mentioned this pull request Jun 20, 2016

Deployment issues for 1.3 #9450

Closed

10 tasks

smarterclayton reviewed Jun 23, 2016
View reviewed changes

0xmichalis added this to the 1.3.0 milestone Jun 25, 2016

mfojtik reviewed Jun 29, 2016
View reviewed changes

0xmichalis mentioned this pull request Jun 29, 2016

oc rollout pause should pause deployer containers #9629

Closed

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2016

0xmichalis added 6 commits June 30, 2016 09:59

oc: port rollout command from kubectl

25c2421

oc: make route utility reusable across packages

396b9eb

oc: generated completions/docs for rollout

8fd2011

oc: support rollout {pause,resume}

58e0192

oc: support rollout history

d3e3fc3

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2016

0xmichalis added 2 commits June 30, 2016 11:42

oc: tests for rollout {pause,resume,history}

96d93f1

oc: support rollout undo

d362664

openshift-bot merged commit 0acacec into openshift:master Jul 1, 2016

0xmichalis deleted the oc-rollout branch July 1, 2016 16:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

oc rollout support #8927

oc rollout support #8927

0xmichalis commented May 18, 2016 •

edited

Loading

0xmichalis commented May 18, 2016

smarterclayton commented May 19, 2016

0xmichalis commented May 19, 2016

smarterclayton commented May 24, 2016

0xmichalis commented May 24, 2016

0xmichalis commented Jun 10, 2016

0xmichalis commented Jun 10, 2016

0xmichalis commented Jun 10, 2016

0xmichalis commented Jun 13, 2016

0xmichalis commented Jun 23, 2016

smarterclayton Jun 23, 2016

0xmichalis Jun 23, 2016

0xmichalis commented Jun 29, 2016

mfojtik Jun 29, 2016

0xmichalis Jun 29, 2016

mfojtik Jun 29, 2016

0xmichalis Jun 29, 2016

mfojtik commented Jun 29, 2016

0xmichalis commented Jun 29, 2016

0xmichalis commented Jun 29, 2016

openshift-bot commented Jun 30, 2016

openshift-bot commented Jun 30, 2016

0xmichalis commented Jul 1, 2016

0xmichalis commented Jul 1, 2016

openshift-bot commented Jul 1, 2016 •

edited

Loading

0xmichalis commented Jul 1, 2016

openshift-bot commented Jul 1, 2016

	DeploymentCancelledByUser = "cancelled by the user"
	DeploymentCancelledNewerDeploymentExists = "cancelled as a newer deployment was found running"
	DeploymentFailedUnrelatedDeploymentExists = "unrelated pod with the same name as this deployment is already running"
	DeploymentFailedDeployerPodNoLongerExists = "deployer pod no longer exists"


		var _ kubectl.Rollbacker = &DeploymentConfigRollbacker{}

		func (r *DeploymentConfigRollbacker) Rollback(namespace, name string, updatedAnnotations map[string]string, toRevision int64, obj runtime.Object) (string, error) {

oc rollout support #8927

oc rollout support #8927

Conversation

0xmichalis commented May 18, 2016 • edited Loading

0xmichalis commented May 18, 2016

smarterclayton commented May 19, 2016

0xmichalis commented May 19, 2016

smarterclayton commented May 24, 2016

0xmichalis commented May 24, 2016

0xmichalis commented Jun 10, 2016

0xmichalis commented Jun 10, 2016

0xmichalis commented Jun 10, 2016

0xmichalis commented Jun 13, 2016

0xmichalis commented Jun 23, 2016

smarterclayton Jun 23, 2016

Choose a reason for hiding this comment

0xmichalis Jun 23, 2016

Choose a reason for hiding this comment

0xmichalis commented Jun 29, 2016

mfojtik Jun 29, 2016

Choose a reason for hiding this comment

0xmichalis Jun 29, 2016

Choose a reason for hiding this comment

mfojtik Jun 29, 2016

Choose a reason for hiding this comment

0xmichalis Jun 29, 2016

Choose a reason for hiding this comment

mfojtik commented Jun 29, 2016

0xmichalis commented Jun 29, 2016

0xmichalis commented Jun 29, 2016

openshift-bot commented Jun 30, 2016

openshift-bot commented Jun 30, 2016

0xmichalis commented Jul 1, 2016

0xmichalis commented Jul 1, 2016

openshift-bot commented Jul 1, 2016 • edited Loading

0xmichalis commented Jul 1, 2016

openshift-bot commented Jul 1, 2016

0xmichalis commented May 18, 2016 •

edited

Loading

openshift-bot commented Jul 1, 2016 •

edited

Loading