UPSTREAM: 23213: provide best effort generation even if types are asy… #8194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6289,7 +6446,8 @@ func autoConvert_v1beta3_PodSpec_To_api_PodSpec(in *apiv1beta3.PodSpec, out *api | |||
| // in.HostIPC has no peer in out | |||
| // unable to generate simple pointer conversion for v1beta3.PodSecurityContext -> api.PodSecurityContext | |||
| if in.SecurityContext != nil { | |||
| if err := s.Convert(&in.SecurityContext, &out.SecurityContext, 0); err != nil { | |||
| out.SecurityContext = new(api.PodSecurityContext) | |||
| if err := apiv1beta3.Convert_v1beta3_PodSecurityContext_To_api_PodSecurityContext(in.SecurityContext, out.SecurityContext, s); err != nil { | |||
There was a problem hiding this comment.
Interesting, this was using reflection before which means the custom conversion wasn't even being called.
There was a problem hiding this comment.
not true... reflection calls registered custom conversions
|
[test] |
|
re[test] |
|
Evaluated for origin test up to c51582f |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2459/) |
|
Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again |
openshift-bot
added
the
needs-rebase
openshift-bot
added
needs-rebase
|
@pweil- Bump |
|
merged upstream but generation has been refactored since and we'll get the lastest in our rebase. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mmetrical
kubernetes/kubernetes#23213