UPSTREAM: 23003: support CIDRs in NO_PROXY #8016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also in |
deads2k
force-pushed
the
noproxy-with-cidr
branch
from
3e2db95 to
e84693e
Compare
deads2k
changed the title
|
[test] |
|
Upstream has "looks good to me" (all spelled out actually). |
|
Evaluated for origin test up to a0096de |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2250/) |
|
@liggitt p1 issue, upstream already merged, minor changes in origin. Any comments? |
|
LGTM |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5373/) (Image: devenv-rhel7_3780) |
|
Evaluated for origin merge up to a0096de |
openshift-bot
pushed a commit
that referenced
this pull request
Mar 18, 2016
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7694
@liggitt is the proxy expert, but I think this picks ups locations where we use the built-in go proxy func and replaces it with one respects CIDRs in
NO_PROXY, but otherwise delegates to the built-in func.