refactor build interfaces #760
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| package client | ||
|
|
||
| import ( | ||
| buildapi "github.com/openshift/origin/pkg/build/api" | ||
| osclient "github.com/openshift/origin/pkg/client" | ||
| ) | ||
|
|
||
| // BuildConfigGetter provides methods for getting BuildConfigs | ||
| type BuildConfigGetter interface { | ||
| Get(namespace, name string) (*buildapi.BuildConfig, error) | ||
| } | ||
|
|
||
| // BuildConfigUpdater provides methods for updating BuildConfigs | ||
| type BuildConfigUpdater interface { | ||
| Update(buildConfig *buildapi.BuildConfig) error | ||
| } | ||
|
|
||
| // OSClientBuildConfigClient delegates get and update operations to the OpenShift client interface | ||
| type OSClientBuildConfigClient struct { | ||
| Client osclient.Interface | ||
| } | ||
|
|
||
| // NewOSClientBuildConfigClient creates a new build config client that uses an openshift client to create and get BuildConfigs | ||
| func NewOSClientBuildConfigClient(client osclient.Interface) *OSClientBuildConfigClient { | ||
| return &OSClientBuildConfigClient{Client: client} | ||
| } | ||
|
|
||
| // Get returns a BuildConfig using the OpenShift client. | ||
| func (c OSClientBuildConfigClient) Get(namespace, name string) (*buildapi.BuildConfig, error) { | ||
| return c.Client.BuildConfigs(namespace).Get(name) | ||
| } | ||
|
|
||
| // Update updates a BuildConfig using the OpenShift client. | ||
| func (c OSClientBuildConfigClient) Update(buildConfig *buildapi.BuildConfig) error { | ||
| _, err := c.Client.BuildConfigs(buildConfig.Namespace).Update(buildConfig) | ||
| return err | ||
| } | ||
|
|
||
| // BuildCreator provides methods for creating new Builds | ||
| type BuildCreator interface { | ||
| Create(namespace string, build *buildapi.Build) error | ||
| } | ||
|
|
||
| // BuildUpdater provides methods for updating existing Builds. | ||
| type BuildUpdater interface { | ||
| Update(namespace string, build *buildapi.Build) error | ||
| } | ||
|
|
||
| // OSClientBuildClient deletes build create and update operations to the OpenShift client interface | ||
| type OSClientBuildClient struct { | ||
| Client osclient.Interface | ||
| } | ||
|
|
||
| // NewOSClientBuildClient creates a new build client that uses an openshift client to create builds | ||
| func NewOSClientBuildClient(client osclient.Interface) *OSClientBuildClient { | ||
| return &OSClientBuildClient{Client: client} | ||
| } | ||
|
|
||
| // Create creates builds using the OpenShift client. | ||
| func (c OSClientBuildClient) Create(namespace string, build *buildapi.Build) error { | ||
| _, e := c.Client.Builds(namespace).Create(build) | ||
| return e | ||
| } | ||
|
|
||
| // Update updates builds using the OpenShift client. | ||
| func (c OSClientBuildClient) Update(namespace string, build *buildapi.Build) error { | ||
| _, e := c.Client.Builds(namespace).Update(build) | ||
| return e | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd propose renaming the file to
clients.go, similar to what we have inpkg/client/client.go.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since there are multiple clients in this file, i think i prefer it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more of a convention thing. If you have one file in a package, and you want to call the package a certain something, you generally call the only file in the package the same as the package. That's usually the stronger convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so as soon as we add a second file to this package, the name would be ok, right?