Don't hard-code resourceVersion in watches #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hard-coding of "0" in watches used for reflectors in deployment controller setup. Doing so will cause every watch event to start over from the beginning of time.
Contributor
Author
|
@smarterclayton @pmorie PTAL |
Contributor
|
LGTM [merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/653/) (Image: devenv-fedora_567) |
Contributor
Contributor
|
@ironcladlou shouldn't this apply to builds as well? See here, here and here |
Member
|
@smarterclayton why yes, yes we did https://github.com/openshift/origin/tree/master/assets#debugging-travis-failures @liggitt fixed the current failure here #714 |
Contributor
Author
Good catch, yes. A separate PR would be good. |
Contributor
|
[merge] |
Contributor
|
Evaluated for origin up to d32733d |
Contributor
|
@ironcladlou OK will do so. |
openshift-bot
pushed a commit
that referenced
this pull request
Jan 22, 2015
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hard-coding of "0" in watches used for reflectors in deployment
controller setup. Doing so will cause every watch event to start over
from the beginning of time.