Skip to content

Conversation

@0xmichalis
Copy link
Contributor

@deads2k unit tests are broken w/o this.

[merge]

Fixes #6423

@liggitt
Copy link
Contributor

liggitt commented Dec 19, 2015

Hold on, how did a breaking change make it into master without this?

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4429/) (Image: devenv-rhel7_3001)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 1890ab0

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@0xmichalis
Copy link
Contributor Author

Hold on, how did a breaking change make it into master without this?

If we don't provide a fixed time, then every time these tests run, they are using time.Now() as the current time and times in oc status ("#8 build running for 2 days") will vary (note that test fixtures are using timestamps). We merged #6379 yesterday and the test was using "hours" but now the difference makes up to "days" :)

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 1890ab0

@liggitt
Copy link
Contributor

liggitt commented Dec 19, 2015

Ah, makes sense

@liggitt
Copy link
Contributor

liggitt commented Dec 19, 2015

Though aren't the creation time stamps in the fixture ignored and overwritten at create time?

@0xmichalis
Copy link
Contributor Author

Though aren't the creation time stamps in the fixture ignored and overwritten at create time?

I am not sure this is supposed to happen when adding resources from paths.

@liggitt
Copy link
Contributor

liggitt commented Dec 19, 2015

Ah, fixture loader, not live API requests. Carry on :)

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/8012/)

openshift-bot pushed a commit that referenced this pull request Dec 19, 2015
@openshift-bot openshift-bot merged commit a94d50c into openshift:master Dec 19, 2015
@0xmichalis 0xmichalis deleted the fix-oc-status-test branch December 19, 2015 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants