-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Fix oc status unit test #6425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix oc status unit test #6425
Conversation
|
Hold on, how did a breaking change make it into master without this? |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4429/) (Image: devenv-rhel7_3001) |
|
Evaluated for origin merge up to 1890ab0 |
|
[Test]ing while waiting on the merge queue |
If we don't provide a fixed time, then every time these tests run, they are using time.Now() as the current time and times in oc status ("#8 build running for 2 days") will vary (note that test fixtures are using timestamps). We merged #6379 yesterday and the test was using "hours" but now the difference makes up to "days" :) |
|
Evaluated for origin test up to 1890ab0 |
|
Ah, makes sense |
|
Though aren't the creation time stamps in the fixture ignored and overwritten at create time? |
I am not sure this is supposed to happen when adding resources from paths. |
|
Ah, fixture loader, not live API requests. Carry on :) |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/8012/) |
Merged by openshift-bot
@deads2k unit tests are broken w/o this.
[merge]
Fixes #6423