ImageRepository lookup should check named repos (not just DockerImageRepository) #635

smarterclayton · 2015-01-12T04:58:18Z

Allow ImageRepositoryMapping to accept an ImageRepository Name/Namespace pair along with DockerImageRegistry, make validation detect passing both.
Make Image/ImageRepository/ImageRepositoryMapping much more strict.
Use strict versioning of incoming Docker image metadata structs by integrating them into the conversion framework - stop using go-dockerclient directly (can't break our API accidentally)
Introduce a new GET /imageRepositoryTags/<name>:<tag> endpoint which returns the image that is tagged or a 404.

Sets the stage for allowing build output to point to an IR by name

[test]

openshift-bot · 2015-01-12T05:00:32Z

Origin Test Results: Running (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/704/)

smarterclayton · 2015-01-12T05:00:47Z

@ncdc review. Going to have some changes after this to allow api consumers to get at the DockerImageReference for a tagged image in a single call, want to get this nailed down.

openshift-bot · 2015-01-12T05:14:38Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/736/)

…itory Do not merge until equivalent lookup is supported in OpenShift under openshift/origin#635

smarterclayton · 2015-01-13T18:33:04Z

Upstream item was merged, this is now backwards compatible with old and new registries.

smarterclayton · 2015-01-14T20:54:53Z

[test]

smarterclayton · 2015-01-19T02:11:59Z

@ncdc this is ready for final review, I'll do the rest of the changes later.

smarterclayton · 2015-01-19T04:15:29Z

[test]

ncdc · 2015-01-19T14:49:05Z

hack/test-go.sh

Is this supposed to be commented out?

Yes, see the comment on the commit

On Jan 19, 2015, at 9:49 AM, Andy Goldstein [email protected] wrote:

In hack/test-go.sh:

fi
KUBE_TIMEOUT=${KUBE_TIMEOUT:--timeout 45s}

if [ -z ${KUBE_RACE+x} ]; then

KUBE_RACE="-race"

KUBE_RACE="" #"-race"
Is this supposed to be commented out?

—
Reply to this email directly or view it on GitHub.

Don't worry about this one, Jordan is reviewing it

On Jan 19, 2015, at 9:49 AM, Andy Goldstein [email protected] wrote:

In hack/test-go.sh:

fi
KUBE_TIMEOUT=${KUBE_TIMEOUT:--timeout 45s}

if [ -z ${KUBE_RACE+x} ]; then

KUBE_RACE="-race"

KUBE_RACE="" #"-race"
Is this supposed to be commented out?

—
Reply to this email directly or view it on GitHub.

ncdc · 2015-01-19T17:41:28Z

A few comments, otherwise LGTM

Allow ImageRepositoryMapping to accept an ImageRepository Name/Namespace pair along with DockerImageRegistry, make validation detect passing both. Make Image/ImageRepository/ImageRepositoryMapping much more strict.

Create a new internal object image/api.DockerImage which has two versions, "1.0" and "pre012" to match the docker client and docker registry API versioning. Allow the version of that API to be passed when submitting an image - if not passed, assume that the object is "1.0" (which is our legacy behavior). Clients should set "apiVersion" inside the "DockerImageMetadata" field for maximum forward compatibility to "1.0". TODO: Upstream should allow the ability to decode and default a kind and apiVersion for maximum flexibility.

This endpoint will be used by clients to fetch the latest image for a given resource. Sets the stage for BuildOutput to be an image reference.

smarterclayton · 2015-01-19T20:41:40Z

[merge]

openshift-bot · 2015-01-19T20:42:09Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/627/) (Image: devenv-fedora_552)

openshift-bot · 2015-01-19T20:42:10Z

Evaluated for origin up to 361cdea

Merged by openshift-bot

coveralls · 2016-08-02T14:19:27Z

Changes Unknown when pulling 361cdea on smarterclayton:image_stream_status into * on openshift:master*.

Do not exclude the excluder for atomic-openshift

smarterclayton changed the title ~~ImageRepository lookup should check the OpenShift for <namespace>/<name>~~ ImageRepository lookup should check named repos (not just DockerImageRepository) Jan 12, 2015

smarterclayton mentioned this pull request Jan 12, 2015

Lookup image repository by namespace/name instead of dockerImageRepository openshift/docker-registry-extensions#3

Merged

smarterclayton force-pushed the image_stream_status branch from 7062178 to d4458e3 Compare January 13, 2015 14:59

smarterclayton force-pushed the image_stream_status branch from d4458e3 to 7408b8d Compare January 13, 2015 18:32

smarterclayton mentioned this pull request Jan 13, 2015

Introduce a deployment rollback API #648

Merged

smarterclayton force-pushed the image_stream_status branch from 4aa4f9a to d21e7e8 Compare January 19, 2015 02:11

smarterclayton force-pushed the image_stream_status branch from d21e7e8 to c0fc22e Compare January 19, 2015 03:34

ncdc reviewed Jan 19, 2015
View reviewed changes

smarterclayton added 2 commits January 19, 2015 13:11

UPSTREAM: Disable auto-pull when tag is "latest"

10396b2

smarterclayton force-pushed the image_stream_status branch 4 times, most recently from 338478b to 2187e78 Compare January 19, 2015 19:27

smarterclayton added 4 commits January 19, 2015 14:37

Update end-to-end to use new registry pattern

ebf6180

UPSTREAM: Expose TypeAccessor for objects without metadata

73c559e

Support GET /imageRepositoryTags/<name>:<tag>

361cdea

This endpoint will be used by clients to fetch the latest image for a given resource. Sets the stage for BuildOutput to be an image reference.

smarterclayton force-pushed the image_stream_status branch from 2187e78 to 361cdea Compare January 19, 2015 19:38

openshift-bot pushed a commit that referenced this pull request Jan 19, 2015

Merge pull request #635 from smarterclayton/image_stream_status

7c12a9c

Merged by openshift-bot

openshift-bot merged commit 7c12a9c into openshift:master Jan 19, 2015

0xmichalis mentioned this pull request Feb 12, 2015

Validate image repository #993

Merged

smarterclayton deleted the image_stream_status branch May 18, 2015 02:16

sjenning pushed a commit to sjenning/origin that referenced this pull request Jan 5, 2018

Merge pull request openshift#635 from sdodson/BZ1427375

6488e0e

Do not exclude the excluder for atomic-openshift

ImageRepository lookup should check named repos (not just DockerImageRepository) #635

ImageRepository lookup should check named repos (not just DockerImageRepository) #635

Uh oh!

Conversation

smarterclayton commented Jan 12, 2015

Uh oh!

openshift-bot commented Jan 12, 2015

Uh oh!

smarterclayton commented Jan 12, 2015

Uh oh!

openshift-bot commented Jan 12, 2015

Uh oh!

smarterclayton commented Jan 13, 2015

Uh oh!

smarterclayton commented Jan 14, 2015

Uh oh!

smarterclayton commented Jan 19, 2015

Uh oh!

smarterclayton commented Jan 19, 2015

Uh oh!

ncdc Jan 19, 2015

Choose a reason for hiding this comment

Uh oh!

smarterclayton Jan 19, 2015

Choose a reason for hiding this comment

Uh oh!

smarterclayton Jan 19, 2015

Choose a reason for hiding this comment

Uh oh!

ncdc commented Jan 19, 2015

Uh oh!

smarterclayton commented Jan 19, 2015

Uh oh!

openshift-bot commented Jan 19, 2015

Uh oh!

openshift-bot commented Jan 19, 2015

Uh oh!

coveralls commented Aug 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Aug 2, 2016 •

edited

Loading