Allow using an image as source for a build #6324
Conversation
There was a problem hiding this comment.
@openshift/api-review for API change
@openshift/ui-review for UI impact
There was a problem hiding this comment.
pkg/build/api/v1/types.go
Outdated
There was a problem hiding this comment.
explicitly list the kinds that are supported.
|
addressed comments so far |
|
[test] |
|
Evaluated for origin test up to bb7ce11 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7902/) |
There was a problem hiding this comment.
Isn't this just "secret"? Do we need more than one kind of secret?
There was a problem hiding this comment.
future proofing and make it obvious to the user what the secret is used for?
There was a problem hiding this comment.
Future proofing when we add push secret? Don't buy it. Obvious to the
user? Maybe buy it.
On Thu, Dec 17, 2015 at 1:20 PM, Ben Parees [email protected]
wrote:
In pkg/build/api/v1/types.go
#6324 (comment):@@ -171,6 +176,31 @@ type BuildSource struct {
SourceSecret *kapi.LocalObjectReferencejson:"sourceSecret,omitempty" description:"supported auth methods are: ssh-privatekey"
}+// ImageSource describes an image that is used as source for the build
+type ImageSource struct {
- // From is a reference to an ImageStreamTag, ImageStreamImage, or DockerImage to
- // copy source from.
- From kapi.ObjectReference
json:"from" description:"reference to ImageStreamTag, ImageStreamImage, or DockerImage"
- // Paths is a list of source and destination paths to copy from the image.
- Paths []ImageSourcePath
json:"paths" description:"paths to copy from image"
- // PullSecret is a reference to a secret to be used to pull the image from a registry
- // If the image is pulled from the OpenShift registry, this field does not need to be set.
- PullSecret *kapi.LocalObjectReference
json:"pullSecret,omitempty" description:"overrides the default pull secret for the source image"future proofing and make it obvious to the user what the secret is used
for?—
Reply to this email directly or view it on GitHub
https://github.com/openshift/origin/pull/6324/files#r47940697.
There was a problem hiding this comment.
not necessarily pushsecret, but i'm well past the point of assuming we can predict how this thing might have to evolve in the future.
but if you'll accept it solely on the "more obvious to a user" basis, i can live w/o convincing you we might want additional secrets in the future.
There was a problem hiding this comment.
PullSecret is fine - secrets will probably get cleanup in v2 anyway.
On Thu, Dec 17, 2015 at 3:40 PM, Ben Parees [email protected]
wrote:
In pkg/build/api/v1/types.go
#6324 (comment):@@ -171,6 +176,31 @@ type BuildSource struct {
SourceSecret *kapi.LocalObjectReferencejson:"sourceSecret,omitempty" description:"supported auth methods are: ssh-privatekey"
}+// ImageSource describes an image that is used as source for the build
+type ImageSource struct {
- // From is a reference to an ImageStreamTag, ImageStreamImage, or DockerImage to
- // copy source from.
- From kapi.ObjectReference
json:"from" description:"reference to ImageStreamTag, ImageStreamImage, or DockerImage"
- // Paths is a list of source and destination paths to copy from the image.
- Paths []ImageSourcePath
json:"paths" description:"paths to copy from image"
- // PullSecret is a reference to a secret to be used to pull the image from a registry
- // If the image is pulled from the OpenShift registry, this field does not need to be set.
- PullSecret *kapi.LocalObjectReference
json:"pullSecret,omitempty" description:"overrides the default pull secret for the source image"not necessarily pushsecret, but i'm well past the point of assuming we can
predict how this thing might have to evolve in the future.but if you'll accept it solely on the "more obvious to a user" basis, i
can live w/o convincing you we might want additional secrets in the future.—
Reply to this email directly or view it on GitHub
https://github.com/openshift/origin/pull/6324/files#r47958060.
|
lgtm. @openshift/api-review sign off? |
|
API approved |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4490/) (Image: devenv-rhel7_3068) |
|
looks etcd flaky to me. [merge] |
|
Evaluated for origin merge up to bb7ce11 |
7 participants
Adds a new source type to builds (image) to pull content into the build directory.