Change how we store association between builds and ICTs on DCs for the console overview #5836
Conversation
jwforres
force-pushed
the
fix_trigger_build_association
branch
from
a92256f to
a7bdb6b
Compare
|
@spadgett thoughts? |
assets/app/views/project.html
Outdated
There was a problem hiding this comment.
Assume you didn't mean to put the namespace attr on the closing tag :)
|
This certainly looks cleaner. |
jwforres
force-pushed
the
fix_trigger_build_association
branch
2 times, most recently
from
2c8c10a to
c272112
Compare
jwforres
changed the title
|
@spadgett updated |
assets/app/views/_triggers.html
Outdated
There was a problem hiding this comment.
I think you can use the <status-icon status="build.status.phase"> directive here.
There was a problem hiding this comment.
Yep will clean this up while i'm in here
|
Should we filter the builds that aren't recent from the map so we don't have to iterate over every build every digest loop in _triggers.html? |
jwforres
force-pushed
the
fix_trigger_build_association
branch
2 times, most recently
from
2176287 to
5157bd4
Compare
assets/app/views/_triggers.html
Outdated
There was a problem hiding this comment.
would like to add a css style for this before merging (class = divider), will do that tmrw
There was a problem hiding this comment.
I think we might use that class name already for horizontal dividers
On Tuesday, November 10, 2015, Jessica Forrester [email protected]
wrote:
In assets/app/views/_triggers.html
#5836 (comment):</span> </span>
</span><ang-if="!!['New', 'Pending'].indexOf(build.status.phase)"ng-href="project/{{build.metadata.namespace}}/browse/builds/{{build.metadata.labels.buildconfig}}/{{build.metadata.name}}?tab=logs">View Log</a><a ng-hide="build | isIncompleteBuild" style="margin-left: 5px;" href="" ng-click="hideBuild(build)">Dismiss</a><ang-if="!!['New', 'Pending'].indexOf(build.status.phase)"ng-href="project/{{build.metadata.namespace}}/browse/builds/{{build.metadata.labels.buildconfig}}/{{build.metadata.name}}?tab=logs">View Log</a><span ng-show="!!['New', 'Pending'].indexOf(build.status.phase) && !(build | isIncompleteBuild)" style="color: #999;">|</span>would like to add a css style for this before merging (class = divider),
will do that tmrw—
Reply to this email directly or view it on GitHub
https://github.com/openshift/origin/pull/5836/files#r44470315.
…e console overview
jwforres
force-pushed
the
fix_trigger_build_association
branch
from
5157bd4 to
58b19f3
Compare
|
went with action-divider for now updated, LGTY @spadgett ? |
|
LGTM |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7101/) (Image: devenv-rhel7_2701) |
|
Evaluated for origin merge up to 58b19f3 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 58b19f3 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7101/) |
Merged by openshift-bot
4 participants
Fixes #2975