Add openshift.io/build-config.name label to builds #5493
Conversation
| BuildConfigLabel = "openshift.io/build-config.name" | ||
| // OldBuildConfigLabel was used as BuildConfigLabel before adding namespaces. | ||
| // We keep it for backward compatibility. | ||
| OldBuildConfigLabel = "buildconfig" |
There was a problem hiding this comment.
call it DeprecatedBuildConfigLabel
you should actually go ahead and remove those constants, nothing should be referencing them there. |
Label "buildconfig" is only kept for backward compatibility.
php-coder
force-pushed
the
gh4810_namespaced_build_confg
branch
from
c1a2a41 to
9dff7b1
Compare
|
@bparees I've fixed all your comments. Thanks! |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3857/) (Image: devenv-rhel7_2604) |
|
Evaluated for origin merge up to 9dff7b1 |
|
[Test]ing while waiting on the merge queue |
php-coder
changed the title
|
Evaluated for origin test up to 9dff7b1 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6434/) |
Merged by openshift-bot
@bparees @mfojtik PTAL
I didn't update
pkg/build/api/v1/types.goandpkg/build/api/v1beta3/types.gofiles. I'm not sure about them.Also may be I also should update/fix something in UI because if this change? May be selectors or something else?
Fixes #4810