expose: Set route port #5067
Merged
expose: Set route port #5067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I had a question on the upstream. |
Contributor
Author
|
[test] |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5972/) |
Contributor
Author
|
@smarterclayton should we set the route port only when exposing multiport services or even if the service has only one port? |
Contributor
|
Always set it or the route is subject to breakage if the service adds a port |
Contributor
Author
|
ok |
Contributor
|
Evaluated for origin test up to 315ba7b |
Contributor
|
LGTM [merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3710/) (Image: devenv-rhel7_2512) |
Contributor
|
Evaluated for origin merge up to 315ba7b |
openshift-bot
pushed a commit
that referenced
this pull request
Oct 21, 2015
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5044
Upstream PR: kubernetes/kubernetes#15461
@smarterclayton @pweil- @bparees @thoraxe