Change api version in examples

[jhadvig]

@mfojtik @Kargakis PTAL

[mfojtik]

[test][extended:core]

[mfojtik]

@jhadvig need to make sure none of the tests are reading that files (should not break anything, just want to make sure ;-)

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5929/)

[jhadvig]

@mfojtik yeah Im already doing checks

[deads2k]

I'd like a hold on this until after we've disabled #4992.

Even after we disable that REST endpoint, we should keep at least a few v1beta3 objects as fixtures to make sure the client properly converts and sends to the proper API version.

@ironcladlou

[ironcladlou]

@deads2k

I'd like a hold on this until after we've disabled #4992.
Even after we disable that REST endpoint, we should keep at least a few v1beta3 objects as fixtures to make sure the client properly converts and sends to the proper API version.

I agree; I'm actually stuck on #4992 at the moment tracking down an issue which was only exposed because of the v1beta3 example files used in test-cmd.sh.

[jhadvig]

@ironcladlou agreed.
What about we update only the sample-apps templates with docker and custom build for now and leave others when your PR lands ?

[danmcp]

@jhadvig Bump

[jhadvig]

@deads2k @ironcladlou I've updated the PR to only change the sample-app templates and we can change the rest when #4992 landes.

[openshift-bot]

Evaluated for origin test up to 693d92a

[mfojtik]

LGTM [merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3694/) (Image: devenv-rhel7_2501)

[openshift-bot]

Evaluated for origin merge up to 693d92a