Skip to content

Conversation

@rhcarvalho
Copy link
Contributor

Add examples of how to set environment variables for S2I and Docker strategy builds.

@rhcarvalho
Copy link
Contributor Author

@mfojtik @bparees PTAL

@bparees
Copy link
Contributor

bparees commented Sep 19, 2015

lgtm. should merge after #4562

@rhcarvalho
Copy link
Contributor Author

It won't break anything if merged before... the env is already part of
dockerStrategy, just not used.
On Sep 19, 2015 9:31 PM, "Ben Parees" [email protected] wrote:

lgtm. should merge after #4562
#4562


Reply to this email directly or view it on GitHub
#4735 (comment).

@bparees
Copy link
Contributor

bparees commented Sep 20, 2015

I know but I don't want to confuse people who see it and assume that means
it can be used.

Ben Parees | OpenShift
On Sep 20, 2015 03:36, "Rodolfo Carvalho" [email protected] wrote:

It won't break anything if merged before... the env is already part of
dockerStrategy, just not used.
On Sep 19, 2015 9:31 PM, "Ben Parees" [email protected] wrote:

lgtm. should merge after #4562
#4562


Reply to this email directly or view it on GitHub
#4735 (comment).


Reply to this email directly or view it on GitHub
#4735 (comment).

@bparees
Copy link
Contributor

bparees commented Sep 21, 2015

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3358/) (Image: devenv-fedora_2375)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 37fb5a4

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5071/)

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 37fb5a4

openshift-bot pushed a commit that referenced this pull request Sep 21, 2015
@openshift-bot openshift-bot merged commit fca9b9a into openshift:master Sep 21, 2015
@rhcarvalho rhcarvalho deleted the example-env branch September 21, 2015 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants