Skip to content

NO-JIRA: Update minio image to use source with all supported architectures #31441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jul 29, 2026
Merged

NO-JIRA: Update minio image to use source with all supported architectures #31441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/extended/util/image/image.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ var (
// used by artifact volume tests
"quay.io/crio/artifact:subpath": -1,

// used by cluster-image-registry-operator e2e tests (S3/Minio endpoint test)
"quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z": -1,

// used by cluster-authentication-operator e2e tests (Authentication proxy)
"registry.redhat.io/rhel10/squid:10.2-1784702318": -1,

// used by cluster-image-registry-operator e2e tests (S3/Minio endpoint test)
"quay.io/openshifttest/minio:latest": -1,

@coderabbitai coderabbitai Bot Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect the relevant file and surrounding code.
git ls-files test/extended/util/image/image.go
wc -l test/extended/util/image/image.go
sed -n '1,220p' test/extended/util/image/image.go

# Find the lookup helper and callers.
rg -n "LocationFor\\(|quay.io/openshifttest/minio|openshifttest/minio" test/extended -S

# Show just the relevant definitions/call sites with context.
rg -n -C 3 "func .*LocationFor|quay.io/openshifttest/minio" test/extended/util/image/image.go test/extended -S

Repository: openshift/origin

Length of output: 15528

🏁 Script executed:

#!/bin/bash
set -euo pipefail

sed -n '1,120p' test/extended/util/image/README.md
sed -n '1,120p' test/extended/util/image/zz_generated.txt

# Inspect how the image mapping is generated/applied.
rg -n -C 3 "func GetMappedImages|GetMappedImages\\(|allowedImages|zz_generated" test/extended/util/image -S
sed -n '80,170p' test/extended/util/image/image.go

Repository: openshift/origin

Length of output: 23095

Pin the MinIO image reference to a versioned tag. latest is mutable and disallowed for e2e images; use the published MinIO version here and keep the matching testdata in sync.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/extended/util/image/image.go` at line 78, Update the MinIO image entry
in the image reference map to use the published versioned tag instead of latest,
and update the corresponding matching testdata reference to keep both values
synchronized.

@bertinatto bertinatto Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM, but where exactly are we using this image?

@jubittajohn jubittajohn Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/openshift/cluster-image-registry-operator/pull/1343/changes#diff-c21f359c274101db5057a1bd6116239e8d55bedc25ff3234907dec7670c2da42R23 - here the PR isn't merged. But this will require updatiion as well. cc: @gangwgr

@bertinatto bertinatto Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, thanks for clarifying.

}
)

Expand Down
2 changes: 1 addition & 1 deletion test/extended/util/image/zz_generated.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ quay.io/crio/artifact:subpath quay.io/openshift/community-e2e-images:e2e-quay-io
quay.io/crio/zstd-chunked:2 quay.io/openshift/community-e2e-images:e2e-quay-io-crio-zstd-chunked-2-8Uf42eAKe3YN2nwu
quay.io/keycloak/keycloak:25.0 quay.io/openshift/community-e2e-images:e2e-quay-io-keycloak-keycloak-25-0-rEIw9B2Zcc3L1M6k
quay.io/kubevirt/fedora-with-test-tooling-container-disk:20241024_891122a6fc quay.io/openshift/community-e2e-images:e2e-quay-io-kubevirt-fedora-with-test-tooling-container-disk-20241024_891122a6fc-IycYTh-87XrXse4E
quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z quay.io/openshift/community-e2e-images:e2e-quay-io-minio-minio-RELEASE-2025-09-07T16-13-09Z-vEhi3VtwtVplkeun
quay.io/olmtest/webhook-operator:v0.0.5 quay.io/openshift/community-e2e-images:e2e-quay-io-olmtest-webhook-operator-v0-0-5--2OhUsk-Xv-pLaTI
quay.io/openshifttest/ldap:1.2 quay.io/openshift/community-e2e-images:e2e-quay-io-openshifttest-ldap-1-2-O3f5zPgtmWzEtasv
quay.io/openshifttest/minio:latest quay.io/openshift/community-e2e-images:e2e-quay-io-openshifttest-minio-latest-p_yqYDk9rEgphwXT
quay.io/redhat-developer/nfs-server:1.1 quay.io/openshift/community-e2e-images:e2e-quay-io-redhat-developer-nfs-server-1-1-dlXGfzrk5aNo8EjC
quay.io/redhat-developer/test-build-roots2i:1.2 quay.io/openshift/community-e2e-images:e2e-quay-io-redhat-developer-test-build-roots2i-1-2-gLJ7WcnS2TSllJ32
quay.io/redhat-developer/test-build-simples2i:1.2 quay.io/openshift/community-e2e-images:e2e-quay-io-redhat-developer-test-build-simples2i-1-2-thirLMR-JKplfkmE
Expand Down