OCPSTRAT-886: Support dual-stack LB in service disruption monitor by alebedev87 · Pull Request #30936 · openshift/origin

alebedev87 · 2026-03-26T09:40:44Z

Configure the service load balancer disruption test to use NLB with RequireDualStack IP family policy when the Infrastructure CR indicates dual-stack IP families on AWS, matching the primary IP family order.

Failure on IPv6Primary cluster:

: [Monitor:service-type-load-balancer-availability][Jira:"Networking / router"] monitor test service-type-load-balancer-availability preparation expand_less	15m0s
{  failed during preparation
error waiting for load balancer: timed out waiting for service "service-test" to have a load balancer: context deadline exceeded}

Example of a failed job: link.

openshift-ci-robot · 2026-03-26T09:40:47Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

coderabbitai · 2026-03-26T09:41:13Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 008f6c27-d275-4eab-a424-69ab48b25db7

📥 Commits

Reviewing files that changed from the base of the PR and between ffa7b5a and ed71c18.

📒 Files selected for processing (1)

pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go

🚧 Files skipped from review as they are similar to previous changes (1)

pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go

Walkthrough

Inspect Infrastructure CR AWS IPFamily and, when dual-stack, annotate TCP LoadBalancer services for NLB and set Service.Spec.IPFamilyPolicy to RequireDualStack with IPFamilies ordered per AWS primary IP family (IPv4-primary or IPv6-primary).

Changes

Cohort / File(s)	Summary
AWS Dual-Stack LoadBalancer Configuration `pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go`	On TCP Service creation, if `infra.Status.PlatformStatus.AWS` is non-nil and `IPFamily` is `DualStackIPv4Primary` or `DualStackIPv6Primary`, set `service.beta.kubernetes.io/aws-load-balancer-type: "nlb"`, `Spec.IPFamilyPolicy = RequireDualStack`, and `Spec.IPFamilies` to `[IPv4, IPv6]` or `[IPv6, IPv4]` respectively. No dual-stack fields are set for other/undefined values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-03-26T10:09:26Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

alebedev87 · 2026-03-26T10:18:38Z

/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/cloud-provider-aws#135

openshift-ci · 2026-03-26T10:18:58Z

@alebedev87, testwith: could not generate prow job. ERROR:

no ref for requested test included in command. The org, repo, and branch containing the requested test need to be targeted by at least one of the included PRs

alebedev87 · 2026-03-26T11:02:06Z

/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/cloud-provider-aws#135

openshift-ci · 2026-03-26T11:02:12Z

@alebedev87, testwith: could not generate prow job. ERROR:

no ref for requested test included in command. The org, repo, and branch containing the requested test need to be targeted by at least one of the included PRs

alebedev87 · 2026-03-26T11:04:38Z

/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/cloud-provider-aws#135

openshift-ci · 2026-03-26T11:04:43Z

@alebedev87, testwith: could not generate prow job. ERROR:

no ref for requested test included in command. The org, repo, and branch containing the requested test need to be targeted by at least one of the included PRs

alebedev87 · 2026-03-26T11:07:50Z

/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/cloud-provider-aws#135 openshift/installer#10380

nrb · 2026-03-26T12:58:56Z

pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go

+				s.Annotations["service.beta.kubernetes.io/aws-load-balancer-type"] = "nlb"
+				dualStack := corev1.IPFamilyPolicyRequireDualStack
+				s.Spec.IPFamilyPolicy = &dualStack


Minor and shouldn't block merging if it's passing tests, but could we move these 3 lines out of the case statements so it's more clear that the only variable is the order of IP families?

Yeah, the boilerplate bothered me too. I tried a couple of approaches but they brought even more code. If you have an idea, I'm open for suggestions.

I am a little late to the party, but we probably can try something like:

// Configure dual-stack if the Infrastructure CR indicates dual-stack IP families. // NLB is required on AWS for dual-stack load balancers. if infra.Status.PlatformStatus.AWS != nil { var ipFamilies []corev1.IPFamily switch infra.Status.PlatformStatus.AWS.IPFamily { case configv1.DualStackIPv4Primary: ipFamilies = []corev1.IPFamily{corev1.IPv4Protocol, corev1.IPv6Protocol} case configv1.DualStackIPv6Primary: ipFamilies = []corev1.IPFamily{corev1.IPv6Protocol, corev1.IPv4Protocol} } if len(ipFamilies) > 1 { s.Annotations["service.beta.kubernetes.io/aws-load-balancer-type"] = "nlb" dualStack := corev1.IPFamilyPolicyRequireDualStack s.Spec.IPFamilyPolicy = &dualStack s.Spec.IPFamilies = ipFamilies } }

Not blocking though as tests passed 😁

Good idea! Thanks @tthvo! Updated the PR.

alebedev87 · 2026-03-26T16:22:27Z

: [Monitor:service-type-load-balancer-availability][Jira:"Networking / router"] monitor test service-type-load-balancer-availability preparation

The modified test passed for the dualstack-ipv6primary job but interesting that it failed on the presubmit, all is pointing to some hiccups from AWS, retrying to be sure..

/test e2e-aws-ovn-fips

Configure the service load balancer disruption test to use NLB with `RequireDualStack` IP family policy when the Infrastructure CR indicates dual-stack IP families on AWS, matching the primary IP family order.

openshift-ci-robot · 2026-03-27T08:33:37Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

alebedev87 · 2026-03-27T15:32:47Z

FIPS job is broken, latest router changes are suspected, Claude Code points to a TLS curve which is not available in FIPS:

Here are the router logs. The root cause is crystal clear at lines 17-26:                                                          
                                      
  error reloading router: exit status 1                                                                                              
  [NOTICE]   (13) : haproxy version is 2.8.18-ae90be6                                                                                
  [ALERT]    (13) : config : Proxy 'fe_sni': unable to set SSL curves list to                                                        
    'X25519MLKEM768:X25519:P-256' for bind 'unix@/var/lib/haproxy/run/haproxy-sni.sock'                                              
  [ALERT]    (13) : config : Proxy 'fe_no_sni': unable to set SSL curves list to                                                     
    'X25519MLKEM768:X25519:P-256' for bind 'unix@/var/lib/haproxy/run/haproxy-no-sni.sock'                                           
  [ALERT]    (13) : config : Fatal errors found in configuration.                                                                    
                                                                                                                                     
  HAProxy cannot start because it's unable to set the SSL curves list to X25519MLKEM768:X25519:P-256. This is a FIPS-specific issue —
   the X25519MLKEM768 curve (a post-quantum key exchange algorithm) is not available in FIPS mode because it's not FIPS-approved.    
  HAProxy exits with a fatal configuration error, so:                                                                                
              
  1. HAProxy never starts -> no socket at /var/lib/haproxy/run/haproxy.sock                                                          
  2. The backend-proxy-http healthz check fails (connection refused on port 80)
  3. Startup probe kills the container after repeated failures                                                                       
  4. Both router pods enter CrashLoopBackOff                                                                                         
  5. Ingress operator reports unavailable -> authentication and console also fail                                                    
  6. Installation times out

alebedev87 · 2026-03-27T20:19:32Z

/test e2e-vsphere-ovn-upi
/test e2e-metal-ipi-ovn-ipv6

tthvo

/lgtm

nrb · 2026-03-27T21:09:42Z

/lgtm

alebedev87 · 2026-03-29T20:05:34Z

/test e2e-aws-ovn-fips

ShudiLi · 2026-03-30T01:06:07Z

/verified by e2e

openshift-ci-robot · 2026-03-30T01:06:19Z

@ShudiLi: This PR has been marked as verified by e2e.

Details

In response to this:

/verified by e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2026-03-30T19:09:15Z

/approve

sadasu · 2026-03-30T19:11:51Z

/retitle NO-JIRA: Support dual-stack LB in service disruption monitor

openshift-ci-robot · 2026-03-30T19:12:03Z

@alebedev87: This pull request explicitly references no jira issue.

Details

In response to this:

Configure the service load balancer disruption test to use NLB with RequireDualStack IP family policy when the Infrastructure CR indicates dual-stack IP families on AWS, matching the primary IP family order.

Failure on IPv6Primary cluster:
: [Monitor:service-type-load-balancer-availability][Jira:"Networking / router"] monitor test service-type-load-balancer-availability preparation expand_less	15m0s
{  failed during preparation
error waiting for load balancer: timed out waiting for service "service-test" to have a load balancer: context deadline exceeded}
Example of a failed job: link.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-31T08:04:08Z

@alebedev87: This pull request references OCPSTRAT-886 which is a valid jira issue.

Details

In response to this:

Configure the service load balancer disruption test to use NLB with RequireDualStack IP family policy when the Infrastructure CR indicates dual-stack IP families on AWS, matching the primary IP family order.

Failure on IPv6Primary cluster:
: [Monitor:service-type-load-balancer-availability][Jira:"Networking / router"] monitor test service-type-load-balancer-availability preparation expand_less	15m0s
{  failed during preparation
error waiting for load balancer: timed out waiting for service "service-test" to have a load balancer: context deadline exceeded}
Example of a failed job: link.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

neisw · 2026-03-31T13:56:27Z

/approve

openshift-ci · 2026-03-31T13:57:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, neisw, nrb, sadasu, tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [neisw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-03-31T14:34:22Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

alebedev87 · 2026-03-31T18:37:35Z

/test e2e-aws-ovn-serial-1of2

alebedev87 · 2026-03-31T19:02:53Z

/test e2e-aws-ovn-fips

openshift-ci · 2026-03-31T23:24:59Z

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot requested review from p0lyn0mial and sjenning March 26, 2026 09:42

nrb reviewed Mar 26, 2026

View reviewed changes

Support dual-stack LB in service disruption monitor test

ed71c18

Configure the service load balancer disruption test to use NLB with `RequireDualStack` IP family policy when the Infrastructure CR indicates dual-stack IP families on AWS, matching the primary IP family order.

alebedev87 force-pushed the dual-stack-disruption-monitor-fix branch from ffa7b5a to ed71c18 Compare March 27, 2026 08:05

tthvo reviewed Mar 27, 2026

View reviewed changes

openshift-ci bot assigned tthvo Mar 27, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 30, 2026

openshift-ci bot changed the title ~~Support dual-stack LB in service disruption monitor test~~ NO-JIRA: Support dual-stack LB in service disruption monitor Mar 30, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 30, 2026

alebedev87 changed the title ~~NO-JIRA: Support dual-stack LB in service disruption monitor~~ OCPSTRAT-886: Support dual-stack LB in service disruption monitor Mar 31, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2026

openshift-merge-bot bot merged commit 5f58686 into openshift:main Mar 31, 2026
21 checks passed

Conversation

alebedev87 commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 26, 2026

Uh oh!

coderabbitai bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci-robot commented Mar 26, 2026

Uh oh!

alebedev87 commented Mar 26, 2026

Uh oh!

openshift-ci bot commented Mar 26, 2026

Uh oh!

alebedev87 commented Mar 26, 2026

Uh oh!

openshift-ci bot commented Mar 26, 2026

Uh oh!

alebedev87 commented Mar 26, 2026

Uh oh!

openshift-ci bot commented Mar 26, 2026

Uh oh!

alebedev87 commented Mar 26, 2026

Uh oh!

nrb Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

alebedev87 Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

tthvo Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

alebedev87 Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

alebedev87 commented Mar 26, 2026

Uh oh!

openshift-ci-robot commented Mar 27, 2026

Uh oh!

alebedev87 commented Mar 27, 2026

Uh oh!

alebedev87 commented Mar 27, 2026

Uh oh!

tthvo left a comment

Choose a reason for hiding this comment

Uh oh!

nrb commented Mar 27, 2026

Uh oh!

alebedev87 commented Mar 29, 2026

Uh oh!

ShudiLi commented Mar 30, 2026

Uh oh!

openshift-ci-robot commented Mar 30, 2026

Uh oh!

sadasu commented Mar 30, 2026

Uh oh!

sadasu commented Mar 30, 2026

Uh oh!

openshift-ci-robot commented Mar 30, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neisw commented Mar 31, 2026

Uh oh!

openshift-ci bot commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026

Uh oh!

alebedev87 commented Mar 31, 2026

Uh oh!

alebedev87 commented Mar 31, 2026

Uh oh!

openshift-ci bot commented Mar 31, 2026

Uh oh!

alebedev87 commented Mar 26, 2026 •

edited

Loading

coderabbitai bot commented Mar 26, 2026 •

edited

Loading

openshift-ci-robot commented Mar 31, 2026 •

edited by openshift-ci bot

Loading