Skip to content

SPLAT-2672: e2e/ote/ccm-aws: moving binary to cccmo#30864

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
mtulio:e2e-ote-ccm-aws
Apr 2, 2026
Merged

SPLAT-2672: e2e/ote/ccm-aws: moving binary to cccmo#30864
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
mtulio:e2e-ote-ccm-aws

Conversation

@mtulio
Copy link
Copy Markdown
Contributor

@mtulio mtulio commented Mar 11, 2026

Blocked by openshift/cluster-cloud-controller-manager-operator#437

SPLAT-2672

Summary by CodeRabbit

  • Chores
    • Updated test extension registry entries for AWS cloud controller manager tests to use the revised image name and updated binary path.

@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 11, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 11, 2026

@mtulio: This pull request references SPLAT-2672 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WRT openshift/cluster-cloud-controller-manager-operator#437

SPLAT-2672

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 11, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 11, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ee2ae5a6-5831-48d7-95d6-03cf5e1e23b2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Updates a single test extension registry entry in pkg/test/extensions/binary.go, changing the AWS cloud controller manager image tag and the associated binary path; no control-flow or logic changes.

Changes

Cohort / File(s) Summary
AWS Test Extension Registry
pkg/test/extensions/binary.go
Updated imageTag from "aws-cloud-controller-manager" to "cluster-cloud-controller-manager-operator" and binaryPath from "/usr/bin/aws-cloud-controller-manager-tests-ext.gz" to "/usr/bin/cloud-controller-manager-aws-tests-ext.gz".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references moving a binary for the ccm-aws (cloud controller manager AWS) project, which aligns with the actual changes that update imageTag and binaryPath in the extension binaries registry for AWS cloud controller manager tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed The file contains no Ginkgo test definitions and changes are configuration entries mapping image tags to binary paths, not test titles with dynamic information.
Test Structure And Quality ✅ Passed The PR modifies only configuration registry data in binary.go, not Ginkgo test code. The custom check for test code quality is not applicable to configuration/metadata updates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 11, 2026

@mtulio: This pull request references SPLAT-2672 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WRT openshift/cluster-cloud-controller-manager-operator#437

SPLAT-2672

Summary by CodeRabbit

  • Chores
  • Updated test extension registry entries for AWS cloud controller manager tests, including associated binary identifiers and file paths to reflect current deployment configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 12, 2026

@mtulio: This pull request references SPLAT-2672 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WRT openshift/cluster-cloud-controller-manager-operator#437

SPLAT-2672

Summary by CodeRabbit

  • Chores
  • Updated test extension registry entries for AWS cloud controller manager tests to use the revised image name and updated binary path.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mtulio added a commit to mtulio/cluster-cloud-controller-manager-operator that referenced this pull request Mar 17, 2026
Adjust the build image for CCCMO project to pack the OTE binary into the
image - which is available in payload, required by OTE extractor
(openshift-tests utility).

The image is compressed, the decompression is done by client side when
extracting it.

PR adding the extraction: openshift/origin#30864
mtulio added a commit to mtulio/cluster-cloud-controller-manager-operator that referenced this pull request Mar 18, 2026
Adjust the build image for CCCMO project to pack the OTE binary into the
image - which is available in payload, required by OTE extractor
(openshift-tests utility).

The image is compressed, the decompression is done by client side when
extracting it.

PR adding the extraction: openshift/origin#30864
mtulio added a commit to mtulio/cluster-cloud-controller-manager-operator that referenced this pull request Mar 18, 2026
Adjust the build image for CCCMO project to pack the OTE binary into the
image - which is available in payload, required by OTE extractor
(openshift-tests utility).

The image is compressed, the decompression is done by client side when
extracting it.

PR adding the extraction: openshift/origin#30864
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 31, 2026

@mtulio: This pull request references SPLAT-2672 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Blocked by openshift/cluster-cloud-controller-manager-operator#437

SPLAT-2672

Summary by CodeRabbit

  • Chores
  • Updated test extension registry entries for AWS cloud controller manager tests to use the revised image name and updated binary path.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio mtulio changed the title DNM/SPLAT-2672: e2e/ote/ccm-aws: moving binary cccmo project SPLAT-2672: e2e/ote/ccm-aws: moving binary cccmo project Mar 31, 2026
@mtulio mtulio changed the title SPLAT-2672: e2e/ote/ccm-aws: moving binary cccmo project SPLAT-2672: e2e/ote/ccm-aws: moving binary to cccmo Mar 31, 2026
@mtulio mtulio marked this pull request as ready for review March 31, 2026 12:42
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2026
@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Mar 31, 2026

PR openshift/cluster-cloud-controller-manager-operator#437 is about to be merged, it was well-exercised through payload jobs openshift/cluster-cloud-controller-manager-operator#437 (comment)

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial March 31, 2026 12:43
@mtulio mtulio marked this pull request as draft March 31, 2026 12:44
@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Mar 31, 2026

Waiting until we get it in the payload.
/hold

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 31, 2026
@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Mar 31, 2026

PR openshift/cluster-cloud-controller-manager-operator#437 merged

/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift

@vr4manta
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2026
@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Mar 31, 2026

/test unit link verify verify-deps images go-verify-deps

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Mar 31, 2026

/test lint

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Apr 1, 2026

/test e2e-aws-ovn-fips

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Apr 1, 2026

/test e2e-aws-ovn

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Apr 1, 2026

job main-e2e-aws-ovn #2039372675465351168 is green and I can see all tests exposed by binary there:

time="2026-04-01T17:14:00Z" level=info msg="Run image extract for release image \"quay-proxy.ci.openshift.org/openshift/ci@sha256:d247819c79dc5494db2edb6a8fb8fe5e2dc8b9323a8eda9f1cee7a0353936198\" and src \"/usr/bin/cloud-controller-manager-aws-tests-ext.gz\""

...
time="2026-04-01T17:14:08Z" level=info msg="Fetched info for cloud-controller-manager-aws-tests-ext in 47.129823ms"

....

time="2026-04-01T17:14:09Z" level=info msg="Listed 13 tests in 60.664616ms" binary=cloud-controller-manager-aws-tests-ext

As well, 12/13 tests passing with prefix [cloud-provider-aws-e2e, and 1/13 skipped (as expected because NLB isn't the default type for default router).

/pipeline required

@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@mtulio mtulio marked this pull request as ready for review April 1, 2026 20:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2026
@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Apr 1, 2026

/test ?

@openshift-ci openshift-ci bot requested a review from sjenning April 1, 2026 20:29
@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Apr 1, 2026

/test e2e-aws-ovn-single-node-techpreview

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Apr 1, 2026

/verified by CI #30864 (comment)

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@mtulio: This PR has been marked as verified by CI https://github.com/openshift/origin/pull/30864#issuecomment-4172775506.

Details

In response to this:

/verified by CI #30864 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@neisw
Copy link
Copy Markdown
Contributor

neisw commented Apr 1, 2026

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtulio, neisw, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

@mtulio: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Apr 2, 2026

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit b578433 into openshift:main Apr 2, 2026
23 checks passed
@mtulio mtulio deleted the e2e-ote-ccm-aws branch April 2, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants