CNTRLPLANE-2202: add new exceptions + fail if uncaught default sa usage is detected

[ehearne-redhat]

This PR adds new exceptions previously not caught. It also ensures default service account usage test fail if uncaught exception is found, such as when a new deployment is added to a PR, which does not have an associated service account.

This should hopefully encourage service account usage to be thought of/enforce it when creating new deployments/daemonsets, etc.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@ehearne-redhat: This pull request references CNTRLPLANE-2202 which is a valid jira issue.

Details

In response to this:

This PR is a draft PR until we are certain no new default service account usage has been detected

This PR adds new exceptions previously not caught. It also ensures default service account usage test fail if uncaught exception is found, such as when a new deployment is added to a PR, which does not have an associated service account.

This should hopefully encourage service account usage to be thought of/enforce it when creating new deployments/daemonsets, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[ehearne-redhat]

/test all

[ehearne-redhat]

/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vpshere-ovn-upi

[ehearne-redhat]

/test e2e-vsphere-ovn-upi
/test e2e-gcp-ovn

[ehearne-redhat]

/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2

[ehearne-redhat]

/retest

[openshift-trt]

Job Failure Risk Analysis for sha: 8dc1218

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial	IncompleteTests Tests for this run (23) are below the historical average (692): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

[ehearne-redhat]

/retest

[openshift-ci-robot]

@ehearne-redhat: This pull request references CNTRLPLANE-2202 which is a valid jira issue.

Details

In response to this:

This PR adds new exceptions previously not caught. It also ensures default service account usage test fail if uncaught exception is found, such as when a new deployment is added to a PR, which does not have an associated service account.

This should hopefully encourage service account usage to be thought of/enforce it when creating new deployments/daemonsets, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[smg247]

/lgtm

[ehearne-redhat]

Ran monitoring script again to verify - debug pod in openshift-commatrix namespace is using default service account.

[
  {
    "url": "",
    "output": "pod \"debug-cskkc\" is using the default service account"
  },
  {
    "url": "",
    "output": "pod \"debug-b7lx8\" is using the default service account\npod \"debug-h2qz7\" is using the default service account\npod \"debug-sd2d2\" is using the default service account\npod \"debug-spscw\" is using the default service account\npod \"debug-zzdq8\" is using the default service account"
  }
]

Empty url field means I need to investigate where this is coming from... it could be a PR development.

[ehearne-redhat]

Found https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-multiarch-main-nightly-4.22-ocp-e2e-serial-aws-ovn-multi-x-ax/2024183686357848064

must-gather reveals pod is deleted after tests. Therefore, the debug- pod is not an issue as it isn't in core payload.

Will do a final check in sippy ui before verifying.

[ehearne-redhat]

Sippy UI revealed no new default service account usage. Since the debug- pod isn't running in core, I believe this should be enough to verify the new changes.

I will re-run the tests just to make sure they pass, before adding verified label.

/test all

[ehearne-redhat]

/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[ehearne-redhat]

/test e2e-gcp-ovn

[ehearne-redhat]

/hold

We need to add this openshift-commatrix-test/debug- pod to the exceptions list.

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[ehearne-redhat]

/test e2e-metal-ipi-ovn-ipv6

[ehearne-redhat]

/retest

[ehearne-redhat]

Based off of e2e-metal-ipi-ovn-ipv6 's run history , the test appears to be broken.

[ehearne-redhat]

I will now unhold this PR and re-request review, and perhaps a test override.

/unhold

[smg247]

/lgtm

[smg247]

/override ci/prow/e2e-metal-ipi-ovn-ipv6

[openshift-ci]

@smg247: Overrode contexts on behalf of smg247: ci/prow/e2e-metal-ipi-ovn-ipv6

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehearne-redhat, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [smg247]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ehearne-redhat]

/verified by ehearne-redhat

[openshift-ci-robot]

@ehearne-redhat: This PR has been marked as verified by ehearne-redhat.

Details

In response to this:

/verified by ehearne-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ehearne-redhat]

/refresh

[openshift-ci]

@ehearne-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.